Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 1977633003: Remove RenderFrameImpl::GetFocusedElement. (Closed)

Created:
4 years, 7 months ago by dglazkov
Modified:
4 years, 7 months ago
CC:
blink-reviews, blink-reviews-api_chromium.org, bondd+autofillwatch_chromium.org, browser-components-watch_chromium.org, chromium-reviews, creis+watch_chromium.org, darin-cc_chromium.org, dcheng, dglazkov+blink, estade+watch_chromium.org, gcasto+watchlist_chromium.org, jam, jdonnelly+autofillwatch_chromium.org, mkwst+moarreviews-renderer_chromium.org, mkwst+watchlist-passwords_chromium.org, mlamouri+watch-content_chromium.org, mlamouri+watch-blink_chromium.org, nasko+codewatch_chromium.org, rouslan+autofill_chromium.org, vabr+watchlistautofill_chromium.org, vabr+watchlistpasswordmanager_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove RenderFrameImpl::GetFocusedElement. The concept of WebNode shouldn't really exist in the Blink Onion Soup world. In this particular case, the knowledge of the focused element was already being plumbed in and out of Blink. This patch removes the weaving and the API that caused it. There should be no behavior change, but one of the existing behaviors wasn't covered by tests, so I added it. BUG=606086 TEST= WebPluginContainerTest.CopyFromContextMenu Committed: https://crrev.com/1b1ec427a7fc6c12c6323930b93eee37ee71dc42 Cr-Commit-Position: refs/heads/master@{#393923}

Patch Set 1 #

Patch Set 2 : Compile. #

Patch Set 3 : Run tests. #

Patch Set 4 : Fixes the right click + blur + copy case. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+99 lines, -69 lines) Patch
M components/autofill/content/renderer/page_click_tracker.cc View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M components/autofill/content/renderer/password_autofill_agent.cc View 1 chunk +2 lines, -1 line 0 comments Download
M content/public/renderer/render_frame.h View 1 chunk +0 lines, -4 lines 0 comments Download
M content/renderer/render_frame_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/render_frame_impl.cc View 8 chunks +13 lines, -28 lines 0 comments Download
M content/renderer/render_view_impl.cc View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/web/WebLocalFrameImpl.h View 1 2 3 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/web/WebLocalFrameImpl.cpp View 1 2 3 4 chunks +13 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/web/WebNode.cpp View 1 2 1 chunk +19 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/web/WebRemoteFrameImpl.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/WebRemoteFrameImpl.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/WebViewImpl.cpp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/tests/WebPluginContainerTest.cpp View 1 2 3 1 chunk +36 lines, -2 lines 0 comments Download
M third_party/WebKit/public/web/WebFrame.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/public/web/WebNode.h View 1 2 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 27 (12 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1977633003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1977633003/1
4 years, 7 months ago (2016-05-13 18:16:32 UTC) #2
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: android_arm64_dbg_recipe on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm64_dbg_recipe/builds/65630) linux_chromium_chromeos_compile_dbg_ng on ...
4 years, 7 months ago (2016-05-13 18:34:44 UTC) #4
dglazkov
Compile.
4 years, 7 months ago (2016-05-13 20:16:43 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1977633003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1977633003/20001
4 years, 7 months ago (2016-05-13 20:17:14 UTC) #7
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/227475)
4 years, 7 months ago (2016-05-13 20:49:49 UTC) #9
dglazkov
Run tests.
4 years, 7 months ago (2016-05-13 22:46:30 UTC) #11
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1977633003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1977633003/40001
4 years, 7 months ago (2016-05-13 22:47:14 UTC) #12
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1977633003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1977633003/60001
4 years, 7 months ago (2016-05-14 00:06:25 UTC) #14
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-14 01:52:34 UTC) #16
dglazkov
PTAL. The original code was added in https://codereview.chromium.org/7280001, and was then adorned with https://codereview.chromium.org/15071004. This ...
4 years, 7 months ago (2016-05-14 03:49:25 UTC) #19
esprehn
lgtm
4 years, 7 months ago (2016-05-14 04:14:51 UTC) #21
jam
lgtm
4 years, 7 months ago (2016-05-16 15:52:16 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1977633003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1977633003/60001
4 years, 7 months ago (2016-05-16 15:53:16 UTC) #24
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 7 months ago (2016-05-16 21:13:42 UTC) #25
commit-bot: I haz the power
4 years, 7 months ago (2016-05-16 21:16:02 UTC) #27
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/1b1ec427a7fc6c12c6323930b93eee37ee71dc42
Cr-Commit-Position: refs/heads/master@{#393923}

Powered by Google App Engine
This is Rietveld 408576698