Plumb edit commands to plugins

Plumb edit commands to plugins

If a plugin has focus, it gives the client an opportunity to send it edit commands.

WebFrame::executeCommand now takes in an extra parameter: a node. The node is the currently focused node. If the currently focused node supports edit commands, then the edit command is passed on to the node.

This patch is required for this Chromium side patch: https://codereview.chromium.org/15149006/

This permits functioning Cmd+Left/Right keyboard shortcuts on Mac in <webview>.

This will be tested on the Chromium side.

BUG=230148
R=abarth@chromium.org

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=151492

[abarth-chromium, 2013-05-28 16:34:31]

LGTM with nits

https://codereview.chromium.org/15071004/diff/1001/Source/WebKit/chromium/src...
File Source/WebKit/chromium/src/WebFrameImpl.cpp (right):

https://codereview.chromium.org/15071004/diff/1001/Source/WebKit/chromium/src...
Source/WebKit/chromium/src/WebFrameImpl.cpp:1238: pluginContainer =
static_cast<WebPluginContainerImpl*>(node.pluginContainer());
Should we have an inline helper function that implements this pattern?  I see it
copy/pasted at least once on line 1200.  Generally whenever you find yourself
copy/pasting code, you should consider factoring that code out into a helper
function.

https://codereview.chromium.org/15071004/diff/1001/Source/WebKit/chromium/src...
File Source/WebKit/chromium/src/WebPluginContainerImpl.cpp (right):

https://codereview.chromium.org/15071004/diff/1001/Source/WebKit/chromium/src...
Source/WebKit/chromium/src/WebPluginContainerImpl.cpp:760: WebViewImpl* view =
WebViewImpl::fromPage(m_element->document()->frame()->page());
Do we know that frame() and page() return non-zero here?

[commit-bot: I haz the power, 2013-05-29 04:36:17]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/fsamuel@chromium.org/15071004/11001

[Fady Samuel, 2013-05-29 04:40:06]

Addressed comments. CQ'ing now.

https://codereview.chromium.org/15071004/diff/1001/Source/WebKit/chromium/src...
File Source/WebKit/chromium/src/WebFrameImpl.cpp (right):

https://codereview.chromium.org/15071004/diff/1001/Source/WebKit/chromium/src...
Source/WebKit/chromium/src/WebFrameImpl.cpp:1238: pluginContainer =
static_cast<WebPluginContainerImpl*>(node.pluginContainer());
On 2013/05/28 16:34:31, abarth wrote:
> Should we have an inline helper function that implements this pattern?  I see
it
> copy/pasted at least once on line 1200.  Generally whenever you find yourself
> copy/pasting code, you should consider factoring that code out into a helper
> function.

Done.

https://codereview.chromium.org/15071004/diff/1001/Source/WebKit/chromium/src...
File Source/WebKit/chromium/src/WebPluginContainerImpl.cpp (right):

https://codereview.chromium.org/15071004/diff/1001/Source/WebKit/chromium/src...
Source/WebKit/chromium/src/WebPluginContainerImpl.cpp:760: WebViewImpl* view =
WebViewImpl::fromPage(m_element->document()->frame()->page());
On 2013/05/28 16:34:31, abarth wrote:
> Do we know that frame() and page() return non-zero here?

I believe so, plugins are created only if they're attached (that may change in
the future). For now, this holds true.

[commit-bot: I haz the power, 2013-05-29 08:13:16]

Retried try job too often on win_layout_rel for step(s) webkit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_layout...

[commit-bot: I haz the power, 2013-05-29 09:11:51]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/fsamuel@chromium.org/15071004/11001

[commit-bot: I haz the power, 2013-05-29 11:48:28]

Retried try job too often on win_layout_rel for step(s) webkit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_layout...

[commit-bot: I haz the power, 2013-05-29 12:10:38]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/fsamuel@chromium.org/15071004/11001

[commit-bot: I haz the power, 2013-05-29 14:49:43]

Retried try job too often on win_layout_rel for step(s) webkit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_layout...

[commit-bot: I haz the power, 2013-05-29 16:30:32]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/fsamuel@chromium.org/15071004/11001

[commit-bot: I haz the power, 2013-05-29 19:17:29]

Retried try job too often on win_layout_rel for step(s) webkit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_layout...

[commit-bot: I haz the power, 2013-05-30 02:24:13]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/fsamuel@chromium.org/15071004/11001

[commit-bot: I haz the power, 2013-05-30 04:16:00]

Sorry for I got bad news for ya.
Compile failed with a clobber build on win_layout_rel.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_layout...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[Fady Samuel, 2013-05-30 15:32:03]

Committed patchset #4 manually as r151492 (presubmit successful).