Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Unified Diff: third_party/WebKit/Source/web/WebLocalFrameImpl.h

Issue 1977633003: Remove RenderFrameImpl::GetFocusedElement. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixes the right click + blur + copy case. Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/renderer/render_view_impl.cc ('k') | third_party/WebKit/Source/web/WebLocalFrameImpl.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/web/WebLocalFrameImpl.h
diff --git a/third_party/WebKit/Source/web/WebLocalFrameImpl.h b/third_party/WebKit/Source/web/WebLocalFrameImpl.h
index 48db8e464a885e2c4c0a310f0dfc8598a7fb7152..19b1f74c91f24810ca8cb008e1a5e5ee7b52fb19 100644
--- a/third_party/WebKit/Source/web/WebLocalFrameImpl.h
+++ b/third_party/WebKit/Source/web/WebLocalFrameImpl.h
@@ -146,8 +146,8 @@ public:
WebRange markedRange() const override;
bool firstRectForCharacterRange(unsigned location, unsigned length, WebRect&) const override;
size_t characterIndexForPoint(const WebPoint&) const override;
- bool executeCommand(const WebString&, const WebNode& = WebNode()) override;
- bool executeCommand(const WebString&, const WebString& value, const WebNode& = WebNode()) override;
+ bool executeCommand(const WebString&) override;
+ bool executeCommand(const WebString&, const WebString& value) override;
bool isCommandEnabled(const WebString&) const override;
void enableContinuousSpellChecking(bool) override;
bool isContinuousSpellCheckingEnabled() const override;
@@ -270,8 +270,8 @@ public:
// If the frame hosts a PluginDocument, this method returns the WebPluginContainerImpl
// that hosts the plugin. If the provided node is a plugin, then it runs its
- // WebPluginContainerImpl.
- static WebPluginContainerImpl* pluginContainerFromNode(LocalFrame*, const WebNode&);
+ // WebPluginContainerImpl. Otherwise, uses the currently focused element (if any).
+ static WebPluginContainerImpl* currentPluginContainer(LocalFrame*, Node* = nullptr);
WebViewImpl* viewImpl() const;
« no previous file with comments | « content/renderer/render_view_impl.cc ('k') | third_party/WebKit/Source/web/WebLocalFrameImpl.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698