Add IndexedDBValue wrapper class to group blob info with bits.

Add IndexedDBValue wrapper class to group blob info with bits.
Depends on https://codereview.chromium.org/197023009.

BUG=108012
R=cmumford,jsbell

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=258139

[ericu, 2014-03-13 23:29:49]

Patch #5.

[cmumford, 2014-03-14 00:36:15]

https://codereview.chromium.org/197753011/diff/20001/content/browser/indexed_...
File content/browser/indexed_db/indexed_db_backing_store.h (right):

https://codereview.chromium.org/197753011/diff/20001/content/browser/indexed_...
content/browser/indexed_db/indexed_db_backing_store.h:136: IndexedDBValue&
value,
Did you intend to un-constify this param?

https://codereview.chromium.org/197753011/diff/20001/content/browser/indexed_...
File content/browser/indexed_db/indexed_db_backing_store_unittest.cc (right):

https://codereview.chromium.org/197753011/diff/20001/content/browser/indexed_...
content/browser/indexed_db/indexed_db_backing_store_unittest.cc:45:
IndexedDBValue m_value2;
is m_key3 still needed? Not sure why value3 went away.

https://codereview.chromium.org/197753011/diff/20001/content/browser/indexed_...
File content/browser/indexed_db/indexed_db_callbacks.cc (right):

https://codereview.chromium.org/197753011/diff/20001/content/browser/indexed_...
content/browser/indexed_db/indexed_db_callbacks.cc:261: for (size_t i = 0; i <
values.size(); ++i) {
Since size is not a constant time function wouldn't it be better to use an
iterator?

https://codereview.chromium.org/197753011/diff/20001/content/browser/indexed_...
File content/browser/indexed_db/indexed_db_callbacks.h (right):

https://codereview.chromium.org/197753011/diff/20001/content/browser/indexed_...
content/browser/indexed_db/indexed_db_callbacks.h:85:
std::vector<IndexedDBValue>& values);
Same question about const removal here.

https://codereview.chromium.org/197753011/diff/20001/content/browser/indexed_...
File content/browser/indexed_db/indexed_db_leveldb_coding.cc (right):

https://codereview.chromium.org/197753011/diff/20001/content/browser/indexed_...
content/browser/indexed_db/indexed_db_leveldb_coding.cc:1405: const int64
DatabaseMetaDataKey::kInvalidBlobKey = -1;
Don't we usually put constants at the top of the file?

https://codereview.chromium.org/197753011/diff/20001/content/browser/indexed_...
File content/browser/indexed_db/indexed_db_value.h (right):

https://codereview.chromium.org/197753011/diff/20001/content/browser/indexed_...
content/browser/indexed_db/indexed_db_value.h:1: // Use of this source code is
governed by a BSD-style license that can be
Are you missing the first line of the copyright banner?

[ericu, 2014-03-14 01:17:23]

https://codereview.chromium.org/197753011/diff/20001/content/browser/indexed_...
File content/browser/indexed_db/indexed_db_backing_store.h (right):

https://codereview.chromium.org/197753011/diff/20001/content/browser/indexed_...
content/browser/indexed_db/indexed_db_backing_store.h:136: IndexedDBValue&
value,
On 2014/03/14 00:36:16, cmumford wrote:
> Did you intend to un-constify this param?

It's mutable in the big CL so that the blob info can get passed instead of
copied.  I'll re-const it here, since it doesn't need to be mutable yet.

https://codereview.chromium.org/197753011/diff/20001/content/browser/indexed_...
File content/browser/indexed_db/indexed_db_backing_store_unittest.cc (right):

https://codereview.chromium.org/197753011/diff/20001/content/browser/indexed_...
content/browser/indexed_db/indexed_db_backing_store_unittest.cc:45:
IndexedDBValue m_value2;
On 2014/03/14 00:36:16, cmumford wrote:
> is m_key3 still needed? Not sure why value3 went away.

Nope; neither's used in current code.
Removed.

https://codereview.chromium.org/197753011/diff/20001/content/browser/indexed_...
File content/browser/indexed_db/indexed_db_callbacks.cc (right):

https://codereview.chromium.org/197753011/diff/20001/content/browser/indexed_...
content/browser/indexed_db/indexed_db_callbacks.cc:261: for (size_t i = 0; i <
values.size(); ++i) {
On 2014/03/14 00:36:16, cmumford wrote:
> Since size is not a constant time function wouldn't it be better to use an
> iterator?

Good point.

https://codereview.chromium.org/197753011/diff/20001/content/browser/indexed_...
File content/browser/indexed_db/indexed_db_callbacks.h (right):

https://codereview.chromium.org/197753011/diff/20001/content/browser/indexed_...
content/browser/indexed_db/indexed_db_callbacks.h:85:
std::vector<IndexedDBValue>& values);
On 2014/03/14 00:36:16, cmumford wrote:
> Same question about const removal here.

Done.

https://codereview.chromium.org/197753011/diff/20001/content/browser/indexed_...
File content/browser/indexed_db/indexed_db_leveldb_coding.cc (right):

https://codereview.chromium.org/197753011/diff/20001/content/browser/indexed_...
content/browser/indexed_db/indexed_db_leveldb_coding.cc:1405: const int64
DatabaseMetaDataKey::kInvalidBlobKey = -1;
On 2014/03/14 00:36:16, cmumford wrote:
> Don't we usually put constants at the top of the file?

In this file they go with their classes, so I was following that.
I don't see anything about class constants in the style guide; if they weren't
class-scoped, I'd agree, but I'm not sure we pull them up top for class members.

https://codereview.chromium.org/197753011/diff/20001/content/browser/indexed_...
File content/browser/indexed_db/indexed_db_value.h (right):

https://codereview.chromium.org/197753011/diff/20001/content/browser/indexed_...
content/browser/indexed_db/indexed_db_value.h:1: // Use of this source code is
governed by a BSD-style license that can be
On 2014/03/14 00:36:16, cmumford wrote:
> Are you missing the first line of the copyright banner?

Done.

[jsbell, 2014-03-14 21:41:09]

lgtm if cmumford doesn't have anything else.

[cmumford, 2014-03-17 20:25:39]

On 2014/03/14 21:41:09, jsbell wrote:
> lgtm if cmumford doesn't have anything else.

lgtm

[ericu, 2014-03-18 21:05:18]

The CQ bit was checked by ericu@chromium.org

[commit-bot: I haz the power, 2014-03-18 21:17:45]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ericu@chromium.org/197753011/80001

[commit-bot: I haz the power, 2014-03-18 21:55:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-18 21:55:01]

Try jobs failed on following builders:
  tryserver.chromium on linux_chromium_chromeos_clang_dbg

[ericu, 2014-03-19 18:07:48]

The CQ bit was checked by ericu@chromium.org

[commit-bot: I haz the power, 2014-03-19 18:10:38]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ericu@chromium.org/197753011/140001

[commit-bot: I haz the power, 2014-03-19 20:38:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-19 20:38:56]

Retried try job too often on win_rel for step(s) app_list_unittests,
ash_unittests, aura_unittests, cacheinvalidation_unittests, cc_unittests,
check_deps, check_deps2git, chrome_elf_unittests, chromedriver_unittests,
components_unittests, compositor_unittests, content_browsertests,
content_unittests, crypto_unittests, events_unittests, gfx_unittests,
google_apis_unittests, gpu_unittests, installer_util_unittests, ipc_tests,
jingle_unittests, media_unittests, mini_installer_test, nacl_integration,
ppapi_unittests, printing_unittests, remoting_unittests, sql_unittests,
sync_integration_tests, sync_unit_tests, telemetry_perf_unittests,
telemetry_unittests, views_unittests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[ericu, 2014-03-19 21:18:46]

The CQ bit was checked by ericu@chromium.org

[commit-bot: I haz the power, 2014-03-19 21:20:15]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ericu@chromium.org/197753011/140001

[commit-bot: I haz the power, 2014-03-19 23:08:53]

Change committed as 258139