Add IndexedDBValue wrapper class to group blob info with bits.

content/browser/indexed_db/indexed_db_backing_store.h

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_BROWSER_INDEXED_DB_INDEXED_DB_BACKING_STORE_H_
 #define CONTENT_BROWSER_INDEXED_DB_INDEXED_DB_BACKING_STORE_H_
 
 #include <string>
 #include <vector>
 
@@ skipping 10 matching lines @@
 #include "content/common/indexed_db/indexed_db_key.h"
 #include "content/common/indexed_db/indexed_db_key_path.h"
 #include "content/common/indexed_db/indexed_db_key_range.h"
 #include "third_party/leveldatabase/src/include/leveldb/status.h"
 #include "url/gurl.h"
 
 namespace content {
 
 class LevelDBComparator;
 class LevelDBDatabase;
+struct IndexedDBValue;
 
 class LevelDBFactory {
  public:
   virtual ~LevelDBFactory() {}
   virtual leveldb::Status OpenLevelDB(const base::FilePath& file_name,
                                       const LevelDBComparator* comparator,
                                       scoped_ptr<LevelDBDatabase>* db,
                                       bool* is_disk_full) = 0;
   virtual leveldb::Status DestroyLevelDB(const base::FilePath& file_name) = 0;
 };
@@ skipping 78 matching lines @@
     std::string primary_key_;
     int64 version_;
     DISALLOW_COPY_AND_ASSIGN(RecordIdentifier);
   };
 
   virtual leveldb::Status GetRecord(
       IndexedDBBackingStore::Transaction* transaction,
       int64 database_id,
       int64 object_store_id,
       const IndexedDBKey& key,
-      std::string* record) WARN_UNUSED_RESULT;
+      IndexedDBValue* record) WARN_UNUSED_RESULT;
   virtual leveldb::Status PutRecord(
       IndexedDBBackingStore::Transaction* transaction,
       int64 database_id,
       int64 object_store_id,
       const IndexedDBKey& key,
-      const std::string& value,
+      IndexedDBValue& value,

[cmumford, 2014/03/14 00:36:16]

Did you intend to un-constify this param?

[ericu, 2014/03/14 01:17:23]

It's mutable in the big CL so that the blob info can get passed instead of
copied.  I'll re-const it here, since it doesn't need to be mutable yet.

       RecordIdentifier* record) WARN_UNUSED_RESULT;
   virtual leveldb::Status ClearObjectStore(
       IndexedDBBackingStore::Transaction* transaction,
       int64 database_id,
       int64 object_store_id) WARN_UNUSED_RESULT;
   virtual leveldb::Status DeleteRecord(
       IndexedDBBackingStore::Transaction* transaction,
       int64 database_id,
       int64 object_store_id,
       const RecordIdentifier& record) WARN_UNUSED_RESULT;
@@ skipping 82 matching lines @@
       return Continue(key, NULL, state);
     }
     bool Continue(const IndexedDBKey* key,
                   const IndexedDBKey* primary_key,
                   IteratorState state);
     bool Advance(uint32 count);
     bool FirstSeek();
 
     virtual Cursor* Clone() = 0;
     virtual const IndexedDBKey& primary_key() const;
-    virtual std::string* value() = 0;
+    virtual IndexedDBValue* value() = 0;
     virtual const RecordIdentifier& record_identifier() const;
     virtual bool LoadCurrentRow() = 0;
 
    protected:
     Cursor(LevelDBTransaction* transaction,
            const CursorOptions& cursor_options);
     explicit Cursor(const IndexedDBBackingStore::Cursor* other);
 
     virtual std::string EncodeKey(const IndexedDBKey& key) = 0;
     virtual std::string EncodeKey(const IndexedDBKey& key,
@@ skipping 92 matching lines @@
   const std::string origin_identifier_;
 
   scoped_ptr<LevelDBDatabase> db_;
   scoped_ptr<LevelDBComparator> comparator_;
   base::OneShotTimer<IndexedDBBackingStore> close_timer_;
 };
 
 }  // namespace content
 
 #endif  // CONTENT_BROWSER_INDEXED_DB_INDEXED_DB_BACKING_STORE_H_