Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 197023009: Add IndexedDBBlobInfo class, to be used for IDB Blob support. (Closed)

Created:
6 years, 9 months ago by ericu
Modified:
6 years, 9 months ago
Reviewers:
jsbell, cmumford
CC:
chromium-reviews, jam, alecflett, ericu+idb_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, cmumford, dgrogan, jsbell+idb_chromium.org
Visibility:
Public.

Description

Add IndexedDBBlobInfo class, to be used for IDB Blob support. Note that this depends on https://codereview.chromium.org/198133002 for DatabaseMetaDataKey::kInvalidBlobKey. BUG=108012 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=257719

Patch Set 1 #

Patch Set 2 : Formatting fix. #

Total comments: 18

Patch Set 3 : rolled in feedback #

Patch Set 4 : rolled in Chris's feedback #

Patch Set 5 : Fix clang destructor issue #

Patch Set 6 : Repair my git branch--no actual change #

Patch Set 7 : Make clang happy. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+173 lines, -3 lines) Patch
A content/browser/indexed_db/indexed_db_blob_info.h View 1 2 3 4 1 chunk +72 lines, -0 lines 0 comments Download
A content/browser/indexed_db/indexed_db_blob_info.cc View 1 2 3 4 1 chunk +91 lines, -0 lines 0 comments Download
M content/browser/indexed_db/indexed_db_leveldb_coding.h View 1 2 3 4 5 6 1 chunk +4 lines, -3 lines 0 comments Download
M content/browser/indexed_db/indexed_db_leveldb_coding.cc View 1 2 3 4 5 6 1 chunk +4 lines, -0 lines 0 comments Download
M content/content_browser.gypi View 1 2 3 4 5 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 22 (0 generated)
ericu
Patch #2.
6 years, 9 months ago (2014-03-12 21:08:43 UTC) #1
ericu
On 2014/03/12 21:08:43, ericu wrote: > Patch #2. Whoops--shouldn't have run this through the trybots ...
6 years, 9 months ago (2014-03-12 23:22:02 UTC) #2
jsbell
https://codereview.chromium.org/197023009/diff/20001/content/browser/indexed_db/indexed_db_blob_info.cc File content/browser/indexed_db/indexed_db_blob_info.cc (right): https://codereview.chromium.org/197023009/diff/20001/content/browser/indexed_db/indexed_db_blob_info.cc#newcode12 content/browser/indexed_db/indexed_db_blob_info.cc:12: IndexedDBBlobInfo::IndexedDBBlobInfo() {} Is this useful? Lots of uninitialized fields? ...
6 years, 9 months ago (2014-03-13 00:01:47 UTC) #3
ericu
https://codereview.chromium.org/197023009/diff/20001/content/browser/indexed_db/indexed_db_blob_info.cc File content/browser/indexed_db/indexed_db_blob_info.cc (right): https://codereview.chromium.org/197023009/diff/20001/content/browser/indexed_db/indexed_db_blob_info.cc#newcode12 content/browser/indexed_db/indexed_db_blob_info.cc:12: IndexedDBBlobInfo::IndexedDBBlobInfo() {} On 2014/03/13 00:01:48, jsbell wrote: > Is ...
6 years, 9 months ago (2014-03-13 18:12:38 UTC) #4
cmumford
https://codereview.chromium.org/197023009/diff/20001/content/browser/indexed_db/indexed_db_blob_info.cc File content/browser/indexed_db/indexed_db_blob_info.cc (right): https://codereview.chromium.org/197023009/diff/20001/content/browser/indexed_db/indexed_db_blob_info.cc#newcode1 content/browser/indexed_db/indexed_db_blob_info.cc:1: // Copyright (c) 2013 The Chromium Authors. All rights ...
6 years, 9 months ago (2014-03-13 18:28:46 UTC) #5
ericu
https://codereview.chromium.org/197023009/diff/20001/content/browser/indexed_db/indexed_db_blob_info.cc File content/browser/indexed_db/indexed_db_blob_info.cc (right): https://codereview.chromium.org/197023009/diff/20001/content/browser/indexed_db/indexed_db_blob_info.cc#newcode1 content/browser/indexed_db/indexed_db_blob_info.cc:1: // Copyright (c) 2013 The Chromium Authors. All rights ...
6 years, 9 months ago (2014-03-13 19:31:18 UTC) #6
jsbell
lgtm (you'll need to R/TBR a content OWNER for the gypi change)
6 years, 9 months ago (2014-03-13 20:27:11 UTC) #7
ericu
The CQ bit was checked by ericu@chromium.org
6 years, 9 months ago (2014-03-17 20:09:16 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ericu@chromium.org/197023009/100001
6 years, 9 months ago (2014-03-17 20:09:39 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-17 21:15:57 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on mac_chromium_compile_dbg
6 years, 9 months ago (2014-03-17 21:15:58 UTC) #11
ericu
The CQ bit was checked by ericu@chromium.org
6 years, 9 months ago (2014-03-17 21:34:34 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ericu@chromium.org/197023009/120001
6 years, 9 months ago (2014-03-17 21:37:00 UTC) #13
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-17 21:45:10 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on linux_chromium_clang_dbg
6 years, 9 months ago (2014-03-17 21:45:13 UTC) #15
ericu
The CQ bit was checked by ericu@chromium.org
6 years, 9 months ago (2014-03-18 00:05:40 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ericu@chromium.org/197023009/120001
6 years, 9 months ago (2014-03-18 00:13:54 UTC) #17
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-18 01:16:52 UTC) #18
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=283229
6 years, 9 months ago (2014-03-18 01:16:53 UTC) #19
ericu
The CQ bit was checked by ericu@chromium.org
6 years, 9 months ago (2014-03-18 18:00:59 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ericu@chromium.org/197023009/120001
6 years, 9 months ago (2014-03-18 18:26:53 UTC) #21
commit-bot: I haz the power
6 years, 9 months ago (2014-03-18 20:24:42 UTC) #22
Message was sent while issue was closed. 
Change committed as 257719

Powered by Google App Engine
This is Rietveld 408576698