Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(504)

Unified Diff: chrome/browser/password_manager/password_manager.cc

Issue 19775014: [Passwords, Mac] Don't always prompt to access passwords saved by other browsers (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/password_manager/password_manager.cc
diff --git a/chrome/browser/password_manager/password_manager.cc b/chrome/browser/password_manager/password_manager.cc
index 15bfb8ca7e7c9d1492d8e1b320d0be8ddc5ef65f..1f0fc7812b3a45dcfcd51a6d62c3fe91fa509ccb 100644
--- a/chrome/browser/password_manager/password_manager.cc
+++ b/chrome/browser/password_manager/password_manager.cc
@@ -12,6 +12,7 @@
#include "base/threading/platform_thread.h"
#include "chrome/browser/password_manager/password_form_manager.h"
#include "chrome/browser/password_manager/password_manager_delegate.h"
+#include "chrome/browser/password_manager/password_store.h"
#include "chrome/browser/profiles/profile.h"
#include "chrome/common/chrome_version_info.h"
#include "chrome/common/pref_names.h"
@@ -264,7 +265,11 @@ void PasswordManager::OnPasswordFormsParsed(
*iter,
ssl_valid);
pending_login_managers_.push_back(manager);
- manager->FetchMatchingLoginsFromPasswordStore();
+ PasswordStore::AuthorizationPromptPermission prompt_permission =
+ *password_manager_enabled_ ?
+ PasswordStore::ALLOW_PROMPT :
+ PasswordStore::DISALLOW_PROMPT;
stuartmorgan 2013/08/29 20:39:54 Optional: Looks like it would fit to pull this up
+ manager->FetchMatchingLoginsFromPasswordStore(prompt_permission);
}
}

Powered by Google App Engine
This is Rietveld 408576698