[Passwords, Mac] Don't always prompt to access passwords saved by other browsers

chrome/browser/password_manager/password_store.h

Index: chrome/browser/password_manager/password_store.h
diff --git a/chrome/browser/password_manager/password_store.h b/chrome/browser/password_manager/password_store.h
index 4d6079f2dc7ec1ab1a7b06d8a81be09a8ad64ba0..fa3af226fc6a964808681c28bbc071d0249c8224 100644
--- a/chrome/browser/password_manager/password_store.h
+++ b/chrome/browser/password_manager/password_store.h
@@ -47,6 +47,13 @@ class PasswordStore
       void(Handle, const std::vector<content::PasswordForm*>&)>
       GetLoginsCallback;
 
+  // Whether or not it's acceptable for Chrome to request access to locked
+  // passwords, which requires prompting the user for permission.
+  enum AuthorizationPromptPermission {
+    ALLOW_PROMPT,
+    DISALLOW_PROMPT,
+  };
+
   // PasswordForm vector elements are meant to be owned by the
   // PasswordStoreConsumer. However, if the request is canceled after the
   // allocation, then the request must take care of the deletion.
@@ -105,10 +112,13 @@ class PasswordStore
 
   // Searches for a matching PasswordForm and returns a ID so the async request
   // can be tracked. Implement the PasswordStoreConsumer interface to be
-  // notified on completion.
+  // notified on completion. |permission_to_prompt| controls whether
+  // or not it's permissible to prompt the user to authorize access to locked
+  // passwords. This variable currently is a no-op on platforms other than Mac.

[stuartmorgan, 2013/08/29 20:39:54]

Seems unlikely that anyone would think to come change this comment. How about
"... no-op except on platforms that can prompt for password access (such as
Mac).

   virtual CancelableTaskTracker::TaskId GetLogins(
       const content::PasswordForm& form,
-      PasswordStoreConsumer* consumer);
+      PasswordStoreConsumer* consumer,
+      AuthorizationPromptPermission permission_to_prompt);
 
   // Gets the complete list of PasswordForms that are not blacklist entries--and
   // are thus auto-fillable--and returns a handle so the async request can be
@@ -175,7 +185,8 @@ class PasswordStore
   // (or not), the consumer should be notified.
   virtual void GetLoginsImpl(
       const content::PasswordForm& form,
-      const ConsumerCallbackRunner& callback_runner) = 0;
+      const ConsumerCallbackRunner& callback_runner,
+      AuthorizationPromptPermission authorization_prompt_permission) = 0;
 
   // Finds all non-blacklist PasswordForms, and notifies the consumer.
   virtual void GetAutofillableLoginsImpl(GetLoginsRequest* request) = 0;