Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Unified Diff: chrome/browser/password_manager/password_form_manager.cc

Issue 19775014: [Passwords, Mac] Don't always prompt to access passwords saved by other browsers (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/password_manager/password_form_manager.cc
diff --git a/chrome/browser/password_manager/password_form_manager.cc b/chrome/browser/password_manager/password_form_manager.cc
index 59c5a6a2e16fcf646892747a4edb4440b8930f07..fcebd85256aea2573d343bdd2976d638f2028e48 100644
--- a/chrome/browser/password_manager/password_form_manager.cc
+++ b/chrome/browser/password_manager/password_form_manager.cc
@@ -243,16 +243,13 @@ void PasswordFormManager::Save() {
UpdateLogin();
}
-void PasswordFormManager::FetchMatchingLoginsFromPasswordStore() {
+void PasswordFormManager::FetchMatchingLoginsFromPasswordStore(
+ PasswordStore::AuthorizationPromptPermission permission_to_prompt) {
DCHECK_EQ(state_, PRE_MATCHING_PHASE);
state_ = MATCHING_PHASE;
PasswordStore* password_store = PasswordStoreFactory::GetForProfile(
profile_, Profile::EXPLICIT_ACCESS).get();
- if (!password_store) {
- NOTREACHED();
- return;
- }
stuartmorgan 2013/08/29 20:39:54 Why change this?
- password_store->GetLogins(observed_form_, this);
+ password_store->GetLogins(observed_form_, this, permission_to_prompt);
}
bool PasswordFormManager::HasCompletedMatching() {

Powered by Google App Engine
This is Rietveld 408576698