Define parameter structs of resource messages out of resource_messages.h

Define parameter structs of resource messages out of resource_messages.h

This is a preliminary change for ipc migration. In order to define typemaps between
mojo types and existing IPC related structs, we need to move them out of
resource_messages.h because it cannot be included from headers.

This CL doesn't change the behavior.

BUG=603396
Committed: https://crrev.com/20c94ea9b16a32a26dd1cdfef5c4fce3eb968c84
Cr-Commit-Position: refs/heads/master@{#394335}

[yhirano, 2016-05-16 04:20:36]

Description was changed from

==========
Define ResourceHostMsg_Request in a dedicated header

BUG=603396
==========

to

==========
Define ResourceHostMsg_Request in a dedicated header file

This change replaces ResourceHostMsg_Request with content::ResourceRequest. This
CL does not
change the behavior.

BUG=603396
==========

[yhirano, 2016-05-16 04:20:36]

yhirano@chromium.org changed reviewers:
+ dcheng@chromium.org

[yhirano, 2016-05-16 06:21:17]

Description was changed from

==========
Define ResourceHostMsg_Request in a dedicated header file

This change replaces ResourceHostMsg_Request with content::ResourceRequest. This
CL does not
change the behavior.

BUG=603396
==========

to

==========
Define parameter structs of resource messages out of resource_messages.h

This is a preliminary change for ipc migration. In order to define typemaps
between
mojo types and existing IPC related structs, we need to move them out of
resource_messages.h because it cannot be included from headers.

This CL doesn't change the behavior.

BUG=603396
==========

[yhirano, 2016-05-16 06:23:07]

dcheng@, what do you think about this CL? I think it's needed to address your
comment at https://codereview.chromium.org/1970693002#msg23.

[dcheng, 2016-05-17 02:26:01]

LGTM

https://codereview.chromium.org/1977313002/diff/60001/content/common/resource...
File content/common/resource_request.h (right):

https://codereview.chromium.org/1977313002/diff/60001/content/common/resource...
content/common/resource_request.h:69: // If kDirectNPAPIRequests isn't
specified, then plugin requests get routed
Nit: remove this part of the comment, we don't have NPAPI anymore.

[yhirano, 2016-05-17 12:43:01]

yhirano@chromium.org changed reviewers:
+ jam@chromium.org

[yhirano, 2016-05-17 12:43:02]

+jam@ for OWNER review.

[yhirano, 2016-05-17 12:44:22]

https://codereview.chromium.org/1977313002/diff/60001/content/common/resource...
File content/common/resource_request.h (right):

https://codereview.chromium.org/1977313002/diff/60001/content/common/resource...
content/common/resource_request.h:69: // If kDirectNPAPIRequests isn't
specified, then plugin requests get routed
On 2016/05/17 02:26:01, dcheng wrote:
> Nit: remove this part of the comment, we don't have NPAPI anymore.

Done.

[jam, 2016-05-17 19:39:09]

lgtm

[yhirano, 2016-05-18 01:53:18]

The CQ bit was checked by yhirano@chromium.org

[yhirano, 2016-05-18 01:53:18]

The patchset sent to the CQ was uploaded after l-g-t-m from dcheng@chromium.org
Link to the patchset: https://codereview.chromium.org/1977313002/#ps80001
(title: " ")

[commit-bot: I haz the power, 2016-05-18 01:53:57]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1977313002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1977313002/80001

[commit-bot: I haz the power, 2016-05-18 02:03:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-18 02:03:19]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[yhirano, 2016-05-18 02:06:46]

The CQ bit was checked by yhirano@chromium.org

[commit-bot: I haz the power, 2016-05-18 02:07:35]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1977313002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1977313002/80001

[yhirano, 2016-05-18 04:05:54]

The CQ bit was checked by yhirano@chromium.org

[yhirano, 2016-05-18 04:05:54]

The patchset sent to the CQ was uploaded after l-g-t-m from jam@chromium.org,
dcheng@chromium.org
Link to the patchset: https://codereview.chromium.org/1977313002/#ps100001
(title: " ")

[commit-bot: I haz the power, 2016-05-18 04:06:22]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1977313002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1977313002/100001

[commit-bot: I haz the power, 2016-05-18 05:20:56]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-05-18 05:22:36]

Description was changed from

==========
Define parameter structs of resource messages out of resource_messages.h

This is a preliminary change for ipc migration. In order to define typemaps
between
mojo types and existing IPC related structs, we need to move them out of
resource_messages.h because it cannot be included from headers.

This CL doesn't change the behavior.

BUG=603396
==========

to

==========
Define parameter structs of resource messages out of resource_messages.h

This is a preliminary change for ipc migration. In order to define typemaps
between
mojo types and existing IPC related structs, we need to move them out of
resource_messages.h because it cannot be included from headers.

This CL doesn't change the behavior.

BUG=603396

Committed: https://crrev.com/20c94ea9b16a32a26dd1cdfef5c4fce3eb968c84
Cr-Commit-Position: refs/heads/master@{#394335}
==========

[commit-bot: I haz the power, 2016-05-18 05:22:38]

Patchset 6 (id:??) landed as
https://crrev.com/20c94ea9b16a32a26dd1cdfef5c4fce3eb968c84
Cr-Commit-Position: refs/heads/master@{#394335}