Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Side by Side Diff: content/browser/loader/async_revalidation_manager_unittest.cc

Issue 1977313002: Define parameter structs of resource messages out of resource_messages.h (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/browser/loader/async_revalidation_manager.h" 5 #include "content/browser/loader/async_revalidation_manager.h"
6 6
7 #include <deque> 7 #include <deque>
8 #include <string> 8 #include <string>
9 #include <utility> 9 #include <utility>
10 10
11 #include "base/bind.h" 11 #include "base/bind.h"
12 #include "base/callback.h" 12 #include "base/callback.h"
13 #include "base/macros.h" 13 #include "base/macros.h"
14 #include "base/memory/ptr_util.h" 14 #include "base/memory/ptr_util.h"
15 #include "base/memory/shared_memory_handle.h" 15 #include "base/memory/shared_memory_handle.h"
16 #include "base/pickle.h" 16 #include "base/pickle.h"
17 #include "base/run_loop.h" 17 #include "base/run_loop.h"
18 #include "base/strings/string_util.h" 18 #include "base/strings/string_util.h"
19 #include "content/browser/child_process_security_policy_impl.h" 19 #include "content/browser/child_process_security_policy_impl.h"
20 #include "content/browser/loader/resource_dispatcher_host_impl.h" 20 #include "content/browser/loader/resource_dispatcher_host_impl.h"
21 #include "content/browser/loader/resource_message_filter.h" 21 #include "content/browser/loader/resource_message_filter.h"
22 #include "content/common/child_process_host_impl.h" 22 #include "content/common/child_process_host_impl.h"
23 #include "content/common/resource_messages.h" 23 #include "content/common/resource_messages.h"
24 #include "content/common/resource_request.h"
24 #include "content/public/browser/resource_context.h" 25 #include "content/public/browser/resource_context.h"
25 #include "content/public/common/appcache_info.h" 26 #include "content/public/common/appcache_info.h"
26 #include "content/public/common/process_type.h" 27 #include "content/public/common/process_type.h"
27 #include "content/public/common/resource_type.h" 28 #include "content/public/common/resource_type.h"
28 #include "content/public/test/test_browser_context.h" 29 #include "content/public/test/test_browser_context.h"
29 #include "content/public/test/test_browser_thread_bundle.h" 30 #include "content/public/test/test_browser_thread_bundle.h"
30 #include "ipc/ipc_param_traits.h" 31 #include "ipc/ipc_param_traits.h"
31 #include "net/base/load_flags.h" 32 #include "net/base/load_flags.h"
32 #include "net/base/network_delegate.h" 33 #include "net/base/network_delegate.h"
33 #include "net/http/http_util.h" 34 #include "net/http/http_util.h"
(...skipping 199 matching lines...) Expand 10 before | Expand all | Expand 10 after
233 net::URLRequestContext** request_context) { 234 net::URLRequestContext** request_context) {
234 *resource_context = resource_context_; 235 *resource_context = resource_context_;
235 *request_context = resource_context_->GetRequestContext(); 236 *request_context = resource_context_->GetRequestContext();
236 } 237 }
237 238
238 ResourceContext* resource_context_; 239 ResourceContext* resource_context_;
239 240
240 DISALLOW_COPY_AND_ASSIGN(BlackholeFilter); 241 DISALLOW_COPY_AND_ASSIGN(BlackholeFilter);
241 }; 242 };
242 243
243 ResourceHostMsg_Request CreateResourceRequest(const char* method, 244 ResourceRequest CreateResourceRequest(const char* method,
244 ResourceType type, 245 ResourceType type,
245 const GURL& url) { 246 const GURL& url) {
246 ResourceHostMsg_Request request; 247 ResourceRequest request;
247 request.method = std::string(method); 248 request.method = std::string(method);
248 request.url = url; 249 request.url = url;
249 request.first_party_for_cookies = url; // Bypass third-party cookie blocking. 250 request.first_party_for_cookies = url; // Bypass third-party cookie blocking.
250 request.referrer_policy = blink::WebReferrerPolicyDefault; 251 request.referrer_policy = blink::WebReferrerPolicyDefault;
251 request.load_flags = 0; 252 request.load_flags = 0;
252 request.origin_pid = 0; 253 request.origin_pid = 0;
253 request.resource_type = type; 254 request.resource_type = type;
254 request.request_context = 0; 255 request.request_context = 0;
255 request.appcache_host_id = kAppCacheNoHostId; 256 request.appcache_host_id = kAppCacheNoHostId;
256 request.download_to_file = false; 257 request.download_to_file = false;
(...skipping 37 matching lines...) Expand 10 before | Expand all | Expand 10 after
294 base::RunLoop().RunUntilIdle(); 295 base::RunLoop().RunUntilIdle();
295 } 296 }
296 297
297 void SetResponse(const std::string& headers, const std::string& data) { 298 void SetResponse(const std::string& headers, const std::string& data) {
298 job_factory_->SetResponse(headers, data); 299 job_factory_->SetResponse(headers, data);
299 } 300 }
300 301
301 // Creates a request using the current test object as the filter and 302 // Creates a request using the current test object as the filter and
302 // SubResource as the resource type. 303 // SubResource as the resource type.
303 void MakeTestRequest(int render_view_id, int request_id, const GURL& url) { 304 void MakeTestRequest(int render_view_id, int request_id, const GURL& url) {
304 ResourceHostMsg_Request request = 305 ResourceRequest request =
305 CreateResourceRequest("GET", RESOURCE_TYPE_SUB_RESOURCE, url); 306 CreateResourceRequest("GET", RESOURCE_TYPE_SUB_RESOURCE, url);
306 ResourceHostMsg_RequestResource msg(render_view_id, request_id, request); 307 ResourceHostMsg_RequestResource msg(render_view_id, request_id, request);
307 host_.OnMessageReceived(msg, filter_.get()); 308 host_.OnMessageReceived(msg, filter_.get());
308 base::RunLoop().RunUntilIdle(); 309 base::RunLoop().RunUntilIdle();
309 } 310 }
310 311
311 void EnsureSchemeIsAllowed(const std::string& scheme) { 312 void EnsureSchemeIsAllowed(const std::string& scheme) {
312 ChildProcessSecurityPolicyImpl* policy = 313 ChildProcessSecurityPolicyImpl* policy =
313 ChildProcessSecurityPolicyImpl::GetInstance(); 314 ChildProcessSecurityPolicyImpl::GetInstance();
314 if (!policy->IsWebSafeScheme(scheme)) 315 if (!policy->IsWebSafeScheme(scheme))
(...skipping 15 matching lines...) Expand all
330 net::URLRequest* url_request( 331 net::URLRequest* url_request(
331 host_.GetURLRequest(GlobalRequestID(filter_->child_id(), 1))); 332 host_.GetURLRequest(GlobalRequestID(filter_->child_id(), 1)));
332 ASSERT_TRUE(url_request); 333 ASSERT_TRUE(url_request);
333 334
334 EXPECT_TRUE(url_request->load_flags() & net::LOAD_SUPPORT_ASYNC_REVALIDATION); 335 EXPECT_TRUE(url_request->load_flags() & net::LOAD_SUPPORT_ASYNC_REVALIDATION);
335 } 336 }
336 337
337 TEST_F(AsyncRevalidationManagerTest, AsyncRevalidationNotSupportedForPOST) { 338 TEST_F(AsyncRevalidationManagerTest, AsyncRevalidationNotSupportedForPOST) {
338 SetResponse(net::URLRequestTestJob::test_headers(), "delay complete"); 339 SetResponse(net::URLRequestTestJob::test_headers(), "delay complete");
339 // Create POST request. 340 // Create POST request.
340 ResourceHostMsg_Request request = CreateResourceRequest( 341 ResourceRequest request = CreateResourceRequest(
341 "POST", RESOURCE_TYPE_SUB_RESOURCE, GURL("http://example.com/baz.php")); 342 "POST", RESOURCE_TYPE_SUB_RESOURCE, GURL("http://example.com/baz.php"));
342 ResourceHostMsg_RequestResource msg(0, 1, request); 343 ResourceHostMsg_RequestResource msg(0, 1, request);
343 host_.OnMessageReceived(msg, filter_.get()); 344 host_.OnMessageReceived(msg, filter_.get());
344 base::RunLoop().RunUntilIdle(); 345 base::RunLoop().RunUntilIdle();
345 346
346 net::URLRequest* url_request( 347 net::URLRequest* url_request(
347 host_.GetURLRequest(GlobalRequestID(filter_->child_id(), 1))); 348 host_.GetURLRequest(GlobalRequestID(filter_->child_id(), 1)));
348 ASSERT_TRUE(url_request); 349 ASSERT_TRUE(url_request);
349 350
350 EXPECT_FALSE(url_request->load_flags() & 351 EXPECT_FALSE(url_request->load_flags() &
(...skipping 195 matching lines...) Expand 10 before | Expand all | Expand 10 after
546 // already completed. 547 // already completed.
547 EXPECT_TRUE(NextRequestWasDestroyed()); 548 EXPECT_TRUE(NextRequestWasDestroyed());
548 549
549 // But no others. 550 // But no others.
550 EXPECT_TRUE(IsEmpty()); 551 EXPECT_TRUE(IsEmpty());
551 } 552 }
552 553
553 } // namespace 554 } // namespace
554 555
555 } // namespace content 556 } // namespace content
OLDNEW
« no previous file with comments | « content/browser/loader/async_revalidation_manager.cc ('k') | content/browser/loader/resource_dispatcher_host_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698