Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1398)

Unified Diff: content/browser/loader/async_revalidation_manager_unittest.cc

Issue 1977313002: Define parameter structs of resource messages out of resource_messages.h (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/loader/async_revalidation_manager_unittest.cc
diff --git a/content/browser/loader/async_revalidation_manager_unittest.cc b/content/browser/loader/async_revalidation_manager_unittest.cc
index 09a70929d883223a14c4cb69c82a7fad7424b5e4..f299ad54d0f514adc3e15d2074dca5e5407605eb 100644
--- a/content/browser/loader/async_revalidation_manager_unittest.cc
+++ b/content/browser/loader/async_revalidation_manager_unittest.cc
@@ -21,6 +21,7 @@
#include "content/browser/loader/resource_message_filter.h"
#include "content/common/child_process_host_impl.h"
#include "content/common/resource_messages.h"
+#include "content/common/resource_request.h"
#include "content/public/browser/resource_context.h"
#include "content/public/common/appcache_info.h"
#include "content/public/common/process_type.h"
@@ -240,10 +241,10 @@ class BlackholeFilter : public ResourceMessageFilter {
DISALLOW_COPY_AND_ASSIGN(BlackholeFilter);
};
-ResourceHostMsg_Request CreateResourceRequest(const char* method,
- ResourceType type,
- const GURL& url) {
- ResourceHostMsg_Request request;
+ResourceRequest CreateResourceRequest(const char* method,
+ ResourceType type,
+ const GURL& url) {
+ ResourceRequest request;
request.method = std::string(method);
request.url = url;
request.first_party_for_cookies = url; // Bypass third-party cookie blocking.
@@ -301,7 +302,7 @@ class AsyncRevalidationManagerTest : public ::testing::Test {
// Creates a request using the current test object as the filter and
// SubResource as the resource type.
void MakeTestRequest(int render_view_id, int request_id, const GURL& url) {
- ResourceHostMsg_Request request =
+ ResourceRequest request =
CreateResourceRequest("GET", RESOURCE_TYPE_SUB_RESOURCE, url);
ResourceHostMsg_RequestResource msg(render_view_id, request_id, request);
host_.OnMessageReceived(msg, filter_.get());
@@ -337,7 +338,7 @@ TEST_F(AsyncRevalidationManagerTest, SupportsAsyncRevalidation) {
TEST_F(AsyncRevalidationManagerTest, AsyncRevalidationNotSupportedForPOST) {
SetResponse(net::URLRequestTestJob::test_headers(), "delay complete");
// Create POST request.
- ResourceHostMsg_Request request = CreateResourceRequest(
+ ResourceRequest request = CreateResourceRequest(
"POST", RESOURCE_TYPE_SUB_RESOURCE, GURL("http://example.com/baz.php"));
ResourceHostMsg_RequestResource msg(0, 1, request);
host_.OnMessageReceived(msg, filter_.get());
« no previous file with comments | « content/browser/loader/async_revalidation_manager.cc ('k') | content/browser/loader/resource_dispatcher_host_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698