Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(562)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1979923002: QUIC - enable "delay_tcp_race" parameter by default. It was enabled (Closed)

Created:
4 years, 7 months ago by ramant (doing other things)
Modified:
4 years, 7 months ago
Reviewers:
Ryan Hamilton, xunjieli
CC:
chromium-reviews, cbentzel+watch_chromium.org, mef
Base URL:
https://chromium.googlesource.com/chromium/src.git@reverse_delay_tcp_race_1
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

QUIC - enable "delay_tcp_race" parameter by default. It was enabled before in M52 but was reverted in the following CL. Reenabling it by default. https://codereview.chromium.org/1977303002/ R=rch@chromium.org, xunjieli@chromium.org Committed: https://crrev.com/afccbc06f1938af64c4dd9945ece074e26b6cba6 Cr-Commit-Position: refs/heads/master@{#393869}

Patch Set 1 #

Patch Set 2 : Enable delay_tcp_race in http_netword_session.cc #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -7 lines) Patch
M net/http/http_network_session.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M net/http/http_stream_factory_impl_unittest.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M net/quic/quic_network_transaction_unittest.cc View 1 2 chunks +1 line, -2 lines 0 comments Download
M net/quic/quic_stream_factory_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/url_request/url_request_context_builder.cc View 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Issue 1977303002 Patch 1

Messages

Total messages: 19 (8 generated)
ramant (doing other things)
4 years, 7 months ago (2016-05-15 23:36:20 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1979923002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1979923002/1
4 years, 7 months ago (2016-05-15 23:37:25 UTC) #3
Ryan Hamilton
lgtm. Do you need to update net/http/http_network_session.cc, too?
4 years, 7 months ago (2016-05-15 23:58:32 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: ios-simulator on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/builds/5871)
4 years, 7 months ago (2016-05-16 00:08:52 UTC) #6
ramant (doing other things)
On 2016/05/15 23:58:32, Ryan Hamilton wrote: > lgtm. Do you need to update net/http/http_network_session.cc, too? ...
4 years, 7 months ago (2016-05-16 00:44:29 UTC) #7
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1979923002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1979923002/20001
4 years, 7 months ago (2016-05-16 00:44:54 UTC) #9
Ryan Hamilton
lgtm
4 years, 7 months ago (2016-05-16 01:44:50 UTC) #10
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-16 01:53:29 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1979923002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1979923002/20001
4 years, 7 months ago (2016-05-16 18:16:10 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-16 18:21:25 UTC) #17
commit-bot: I haz the power
4 years, 7 months ago (2016-05-16 18:23:02 UTC) #19
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/afccbc06f1938af64c4dd9945ece074e26b6cba6
Cr-Commit-Position: refs/heads/master@{#393869}

Powered by Google App Engine
This is Rietveld 408576698