Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1983473002: ApplicationConnection devolution, part 3.1. (Closed)

Created:
4 years, 7 months ago by viettrungluu
Modified:
4 years, 7 months ago
Reviewers:
vardhan
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org, yzshen+mojopublicwatch_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

ApplicationConnection devolution, part 3.1. * Remove some ApplicationConnection forward declarations and |using| statements. * Also update the FML/Ozone stuff, which I don't know how to build. * Now we're very close to deleting ApplicationConnection. R=vardhan@google.com Committed: https://chromium.googlesource.com/external/mojo/+/736c850221aaa7ccbc6125bd515f8fd12f35046e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -22 lines) Patch
M examples/apptest/example_service_application.h View 1 chunk +0 lines, -2 lines 0 comments Download
M examples/apptest/example_service_impl.h View 1 chunk +0 lines, -2 lines 0 comments Download
M mojo/public/cpp/application/application_delegate.h View 1 chunk +0 lines, -1 line 0 comments Download
M services/python/content_handler/content_handler_main.cc View 1 chunk +0 lines, -1 line 0 comments Download
M services/test_service/test_request_tracker_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M services/test_service/test_service_application.h View 1 chunk +1 line, -2 lines 0 comments Download
M services/test_service/test_time_service_impl.h View 1 chunk +0 lines, -3 lines 0 comments Download
M shell/android/native_viewport_application_loader.cc View 1 chunk +0 lines, -1 line 0 comments Download
M shell/application_manager/application_manager_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ui/ozone/platform/drm/mojo/drm_ipc_init_helper.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M ui/ozone/public/ipc_init_helper_mojo.h View 1 chunk +2 lines, -2 lines 0 comments Download

Dependent Patchsets:

Issue 1977023003 Patch 1

Messages

Total messages: 4 (1 generated)
viettrungluu
4 years, 7 months ago (2016-05-13 22:34:41 UTC) #1
vardhan
lgtm
4 years, 7 months ago (2016-05-13 23:05:07 UTC) #2
viettrungluu
4 years, 7 months ago (2016-05-13 23:14:54 UTC) #4
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
736c850221aaa7ccbc6125bd515f8fd12f35046e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698