Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(403)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1976933002: [liveedit] patch source position table for bytecode arrays. (Closed)

Created:
4 years, 7 months ago by Yang
Modified:
4 years, 7 months ago
Reviewers:
Michael Starzinger
CC:
v8-reviews_googlegroups.com, Yang
Base URL:
https://chromium.googlesource.com/v8/v8.git@liveedit
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[liveedit] patch source position table for bytecode arrays. R=mstarzinger@chromium.org BUG=v8:4765 Committed: https://crrev.com/7b1fe365a93ef75f402f92a5dacc9436327a385b Cr-Commit-Position: refs/heads/master@{#36240}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -6 lines) Patch
M src/debug/liveedit.cc View 4 chunks +25 lines, -4 lines 0 comments Download
M test/mjsunit/mjsunit.status View 2 chunks +0 lines, -2 lines 0 comments Download

Depends on Patchset:

Issue 1968423002 Patch 40001

Dependent Patchsets:

Issue 1973213003 Patch 1
Issue 1973213003 Patch 20001

Messages

Total messages: 7 (2 generated)
Yang
4 years, 7 months ago (2016-05-13 11:27:30 UTC) #1
Michael Starzinger
LGTM.
4 years, 7 months ago (2016-05-13 12:34:33 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1976933002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1976933002/1
4 years, 7 months ago (2016-05-13 12:53:23 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-13 13:21:00 UTC) #5
commit-bot: I haz the power
4 years, 7 months ago (2016-05-13 13:21:42 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/7b1fe365a93ef75f402f92a5dacc9436327a385b
Cr-Commit-Position: refs/heads/master@{#36240}

Powered by Google App Engine
This is Rietveld 408576698