Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Issue 1968423002: [liveedit] support restarting interpreted frame and replacing bytecode. (Closed)

Created:
4 years, 7 months ago by Yang
Modified:
4 years, 7 months ago
CC:
v8-reviews_googlegroups.com, Yang, rmcilroy
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[liveedit] support restarting interpreted frame and replacing bytecode. R=mstarzinger@chromium.org BUG=v8:4765 Committed: https://crrev.com/72b510dfb34d15a687d39429f43aa74af6e19471 Cr-Commit-Position: refs/heads/master@{#36237}

Patch Set 1 #

Patch Set 2 : also correctly replace code #

Patch Set 3 : skip stack padding test. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -28 lines) Patch
M src/debug/liveedit.cc View 1 3 chunks +21 lines, -3 lines 0 comments Download
M test/mjsunit/mjsunit.status View 1 2 2 chunks +1 line, -25 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 20 (10 generated)
Yang
4 years, 7 months ago (2016-05-12 10:48:07 UTC) #1
Michael Starzinger
LGTM.
4 years, 7 months ago (2016-05-13 10:36:01 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1968423002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1968423002/20001
4 years, 7 months ago (2016-05-13 10:36:31 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: v8_win_nosnap_shared_rel_ng on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_win_nosnap_shared_rel_ng/builds/1674) v8_win_nosnap_shared_rel_ng_triggered on tryserver.v8 (JOB_FAILED, ...
4 years, 7 months ago (2016-05-13 10:57:02 UTC) #7
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1968423002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1968423002/40001
4 years, 7 months ago (2016-05-13 11:11:29 UTC) #9
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-13 11:40:51 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1968423002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1968423002/40001
4 years, 7 months ago (2016-05-13 12:11:40 UTC) #14
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 7 months ago (2016-05-13 12:13:21 UTC) #16
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/72b510dfb34d15a687d39429f43aa74af6e19471 Cr-Commit-Position: refs/heads/master@{#36237}
4 years, 7 months ago (2016-05-13 12:15:06 UTC) #18
Michael Achenbach
4 years, 7 months ago (2016-05-16 10:27:39 UTC) #20
Message was sent while issue was closed.
FYI: This broke the ignition layout test bot:

https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064%20-...

Powered by Google App Engine
This is Rietveld 408576698