Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1973213003: [liveedit] fix stepping after replacing bytecode. (Closed)

Created:
4 years, 7 months ago by Yang
Modified:
4 years, 7 months ago
Reviewers:
Michael Starzinger
CC:
v8-reviews_googlegroups.com, Yang
Base URL:
https://chromium.googlesource.com/v8/v8.git@liveeditbreaks
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[liveedit] fix stepping after replacing bytecode. R=mstarzinger@chromium.org BUG=v8:4765 Committed: https://crrev.com/f248a83d295afc27b29f6b23194f4d7166d606ad Cr-Commit-Position: refs/heads/master@{#36272}

Patch Set 1 #

Patch Set 2 : add another testcase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+83 lines, -21 lines) Patch
M src/debug/liveedit.cc View 2 chunks +7 lines, -1 line 0 comments Download
M src/runtime/runtime-debug.cc View 1 chunk +3 lines, -0 lines 0 comments Download
A test/mjsunit/debug-liveedit-exceptions.js View 1 1 chunk +67 lines, -0 lines 0 comments Download
M test/mjsunit/debug-liveedit-stepin.js View 2 chunks +6 lines, -12 lines 0 comments Download
M test/mjsunit/mjsunit.status View 2 chunks +0 lines, -8 lines 0 comments Download

Depends on Patchset:

Issue 1976933002 Patch 1

Messages

Total messages: 11 (4 generated)
Yang
4 years, 7 months ago (2016-05-13 13:01:50 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1973213003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1973213003/20001
4 years, 7 months ago (2016-05-13 13:10:00 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-13 13:36:51 UTC) #5
Michael Starzinger
LGTM.
4 years, 7 months ago (2016-05-17 08:39:00 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1973213003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1973213003/20001
4 years, 7 months ago (2016-05-17 08:41:34 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-17 09:20:37 UTC) #9
commit-bot: I haz the power
4 years, 7 months ago (2016-05-17 09:22:26 UTC) #11
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/f248a83d295afc27b29f6b23194f4d7166d606ad
Cr-Commit-Position: refs/heads/master@{#36272}

Powered by Google App Engine
This is Rietveld 408576698