Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(751)

Issue 1976603005: Reland of [Reland] Implement CPU time for OS X and POSIX. (Closed)

Created:
4 years, 7 months ago by Michael Hablich
Modified:
4 years, 7 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Reland of [Reland] Implement CPU time for OS X and POSIX. (patchset #1 id:1 of https://codereview.chromium.org/1977753002/ ) Reason for revert: Not the culprit sorry. Original issue's description: > Revert of [Reland] Implement CPU time for OS X and POSIX. (patchset #1 id:1 of https://codereview.chromium.org/1966183003/ ) > > Reason for revert: > Blocks roll: https://codereview.chromium.org/1972303002/ > > Original issue's description: > > [Reland] Implement CPU time for OS X and POSIX. > > > > V8 tracing controller uses 2 clocks: wall clock and cpu clock. This patch > > implements CPU time for OS X and POSIX to provide more accurate > > accounting of CPU time used by each thread. > > > > BUG=v8:4984 > > LOG=n > > > > Committed: https://crrev.com/efa27fb25e1fa5b8465f4af710086b73b0cba660 > > Cr-Commit-Position: refs/heads/master@{#36213} > > TBR=fmeawad@chromium.org,jochen@chromium.org,rsesek@chromium.org,bmeurer@chromium.org,lpy@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=v8:4984 > > Committed: https://crrev.com/31b9ba3bc8fb93601cc73c83213b30e639d448b3 > Cr-Commit-Position: refs/heads/master@{#36225} TBR=fmeawad@chromium.org,jochen@chromium.org,rsesek@chromium.org,bmeurer@chromium.org,lpy@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4984 Committed: https://crrev.com/4505b54a28fa2a0b56c88b22943253fd53db306f Cr-Commit-Position: refs/heads/master@{#36233}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+127 lines, -7 lines) Patch
M src/base/platform/time.h View 2 chunks +26 lines, -1 line 0 comments Download
M src/base/platform/time.cc View 4 chunks +73 lines, -6 lines 0 comments Download
M test/unittests/base/platform/time-unittest.cc View 2 chunks +28 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Michael Hablich
Created Reland of [Reland] Implement CPU time for OS X and POSIX.
4 years, 7 months ago (2016-05-13 11:05:13 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1976603005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1976603005/1
4 years, 7 months ago (2016-05-13 11:05:19 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-13 11:05:35 UTC) #3
commit-bot: I haz the power
4 years, 7 months ago (2016-05-13 11:06:13 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4505b54a28fa2a0b56c88b22943253fd53db306f
Cr-Commit-Position: refs/heads/master@{#36233}

Powered by Google App Engine
This is Rietveld 408576698