Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(172)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1975013003: Add support for std::unique_ptr as this pointer in WTF::bind() (Closed)

Created:
4 years, 7 months ago by hiroshige
Modified:
4 years, 7 months ago
Reviewers:
*Yuta Kitamura, tzik
CC:
blink-reviews, blink-reviews-wtf_chromium.org, chromium-reviews, Mikhail
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add support for std::unique_ptr as this pointer in WTF::bind() BUG=478194 Committed: https://crrev.com/7748fb3e2c1b1d9dfd216fdadbdaf0a94cdd198c Cr-Commit-Position: refs/heads/master@{#393493}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Use const&. Add tests. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -3 lines) Patch
M third_party/WebKit/Source/wtf/Functional.h View 1 3 chunks +9 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/wtf/FunctionalTest.cpp View 1 1 chunk +12 lines, -0 lines 0 comments Download

Dependent Patchsets:

Issue 1976083002 Patch 20001

Messages

Total messages: 18 (8 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1975013003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1975013003/1
4 years, 7 months ago (2016-05-13 07:30:37 UTC) #2
hiroshige
yutak@, PTAL. tzik@, FYI. This will be used in https://codereview.chromium.org/1976083002.
4 years, 7 months ago (2016-05-13 07:31:55 UTC) #5
Yuta Kitamura
LGTM thanks! Yes I forgot to update the comments...
4 years, 7 months ago (2016-05-13 07:34:53 UTC) #6
tzik
lgtm https://codereview.chromium.org/1975013003/diff/1/third_party/WebKit/Source/wtf/Functional.h File third_party/WebKit/Source/wtf/Functional.h (right): https://codereview.chromium.org/1975013003/diff/1/third_party/WebKit/Source/wtf/Functional.h#newcode169 third_party/WebKit/Source/wtf/Functional.h:169: R operator()(std::unique_ptr<C> c, IncomingParameters&&... parameters) Can we use ...
4 years, 7 months ago (2016-05-13 08:16:46 UTC) #7
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1975013003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1975013003/20001
4 years, 7 months ago (2016-05-13 08:36:51 UTC) #9
hiroshige
Done, PTAL. https://codereview.chromium.org/1975013003/diff/1/third_party/WebKit/Source/wtf/Functional.h File third_party/WebKit/Source/wtf/Functional.h (right): https://codereview.chromium.org/1975013003/diff/1/third_party/WebKit/Source/wtf/Functional.h#newcode169 third_party/WebKit/Source/wtf/Functional.h:169: R operator()(std::unique_ptr<C> c, IncomingParameters&&... parameters) On 2016/05/13 ...
4 years, 7 months ago (2016-05-13 08:42:28 UTC) #10
tzik
lgtm
4 years, 7 months ago (2016-05-13 09:17:20 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1975013003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1975013003/20001
4 years, 7 months ago (2016-05-13 09:55:05 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-13 10:17:01 UTC) #16
commit-bot: I haz the power
4 years, 7 months ago (2016-05-13 10:18:23 UTC) #18
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/7748fb3e2c1b1d9dfd216fdadbdaf0a94cdd198c
Cr-Commit-Position: refs/heads/master@{#393493}

Powered by Google App Engine
This is Rietveld 408576698