Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Unified Diff: src/lookup.h

Issue 1975763002: [runtime] Make sure that LookupIterator::OWN always performs a HIDDEN lookup as well. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Addressed comment Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/ic/ic.cc ('k') | src/lookup.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/lookup.h
diff --git a/src/lookup.h b/src/lookup.h
index 13286deea3977cfcf10cc90df0b1c11e374e0161..94a3f2c017b2c55592a9c4a1690ff9c604d8f1c1 100644
--- a/src/lookup.h
+++ b/src/lookup.h
@@ -16,17 +16,14 @@ class LookupIterator final BASE_EMBEDDED {
public:
enum Configuration {
// Configuration bits.
- kHidden = 1 << 0,
- kInterceptor = 1 << 1,
- kPrototypeChain = 1 << 2,
+ kInterceptor = 1 << 0,
+ kPrototypeChain = 1 << 1,
// Convience combinations of bits.
OWN_SKIP_INTERCEPTOR = 0,
OWN = kInterceptor,
- HIDDEN_SKIP_INTERCEPTOR = kHidden,
- HIDDEN = kHidden | kInterceptor,
- PROTOTYPE_CHAIN_SKIP_INTERCEPTOR = kHidden | kPrototypeChain,
- PROTOTYPE_CHAIN = kHidden | kPrototypeChain | kInterceptor,
+ PROTOTYPE_CHAIN_SKIP_INTERCEPTOR = kPrototypeChain,
+ PROTOTYPE_CHAIN = kPrototypeChain | kInterceptor,
DEFAULT = PROTOTYPE_CHAIN
};
@@ -316,7 +313,6 @@ class LookupIterator final BASE_EMBEDDED {
: holder->GetNamedInterceptor();
}
- bool check_hidden() const { return (configuration_ & kHidden) != 0; }
bool check_interceptor() const {
return (configuration_ & kInterceptor) != 0;
}
@@ -335,12 +331,7 @@ class LookupIterator final BASE_EMBEDDED {
static Configuration ComputeConfiguration(
Configuration configuration, Handle<Name> name) {
- if (name->IsPrivate()) {
- return static_cast<Configuration>(configuration &
- HIDDEN_SKIP_INTERCEPTOR);
- } else {
- return configuration;
- }
+ return name->IsPrivate() ? OWN_SKIP_INTERCEPTOR : configuration;
}
static Handle<JSReceiver> GetRootForNonJSReceiver(
« no previous file with comments | « src/ic/ic.cc ('k') | src/lookup.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698