src/ic/ic.cc - Issue 1975763002: [runtime] Make sure that LookupIterator::OWN always performs a HIDDEN lookup as well.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ic/ic.cc

Issue 1975763002: [runtime] Make sure that LookupIterator::OWN always performs a HIDDEN lookup as well. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Addressed comment Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/ic/ic.cc

diff --git a/src/ic/ic.cc b/src/ic/ic.cc

index 68483ef4fda7a4e0b33bc097c23120af0464bf39..05255522d0d5b809250318746b895d080236c94f 100644

--- a/src/ic/ic.cc

+++ b/src/ic/ic.cc

@@ -280,6 +280,7 @@ bool IC::ShouldRecomputeHandler(Handle<Object> receiver, Handle<String> name) {

LookupIterator it(global, name, LookupIterator::OWN_SKIP_INTERCEPTOR);

if (it.state() == LookupIterator::ACCESS_CHECK) return false;

if (!it.IsFound()) return false;

+ if (!it.GetHolder<JSReceiver>()->IsJSGlobalObject()) return false;

return it.property_details().cell_type() == PropertyCellType::kConstant;

}

« no previous file with comments | « src/crankshaft/hydrogen.cc ('k') | src/lookup.h » ('j') | no next file with comments »