[runtime] Make sure that LookupIterator::OWN always performs a HIDDEN lookup as well.

src/lookup.h

 // Copyright 2014 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef V8_LOOKUP_H_
 #define V8_LOOKUP_H_
 
 #include "src/factory.h"
 #include "src/isolate.h"
 #include "src/objects.h"
 
 namespace v8 {
 namespace internal {
 
 class LookupIterator final BASE_EMBEDDED {
  public:
   enum Configuration {
     // Configuration bits.
-    kHidden = 1 << 0,
-    kInterceptor = 1 << 1,
-    kPrototypeChain = 1 << 2,
+    kInterceptor = 1 << 0,
+    kPrototypeChain = 1 << 1,
 
     // Convience combinations of bits.
     OWN_SKIP_INTERCEPTOR = 0,
     OWN = kInterceptor,
-    HIDDEN_SKIP_INTERCEPTOR = kHidden,
-    HIDDEN = kHidden | kInterceptor,
-    PROTOTYPE_CHAIN_SKIP_INTERCEPTOR = kHidden | kPrototypeChain,
-    PROTOTYPE_CHAIN = kHidden | kPrototypeChain | kInterceptor,
+    PROTOTYPE_CHAIN_SKIP_INTERCEPTOR = kPrototypeChain,
+    PROTOTYPE_CHAIN = kPrototypeChain | kInterceptor,
     DEFAULT = PROTOTYPE_CHAIN
   };
 
   enum State {
     ACCESS_CHECK,
     INTEGER_INDEXED_EXOTIC,
     INTERCEPTOR,
     JSPROXY,
     NOT_FOUND,
     ACCESSOR,
@@ skipping 269 matching lines @@
   void ReloadPropertyInformation();
 
   template <bool is_element>
   bool SkipInterceptor(JSObject* holder);
   template <bool is_element>
   inline InterceptorInfo* GetInterceptor(JSObject* holder) const {
     return is_element ? holder->GetIndexedInterceptor()
                       : holder->GetNamedInterceptor();
   }
 
-  bool check_hidden() const { return (configuration_ & kHidden) != 0; }
   bool check_interceptor() const {
     return (configuration_ & kInterceptor) != 0;
   }
   int descriptor_number() const {
     DCHECK(!IsElement());
     DCHECK(has_property_);
     DCHECK(holder_->HasFastProperties());
     return number_;
   }
   int dictionary_entry() const {
     DCHECK(!IsElement());
     DCHECK(has_property_);
     DCHECK(!holder_->HasFastProperties());
     return number_;
   }
 
   static Configuration ComputeConfiguration(
       Configuration configuration, Handle<Name> name) {
-    if (name->IsPrivate()) {
-      return static_cast<Configuration>(configuration &
-                                        HIDDEN_SKIP_INTERCEPTOR);
-    } else {
-      return configuration;
-    }
+    return name->IsPrivate() ? OWN_SKIP_INTERCEPTOR : configuration;
   }
 
   static Handle<JSReceiver> GetRootForNonJSReceiver(
       Isolate* isolate, Handle<Object> receiver, uint32_t index = kMaxUInt32);
   inline static Handle<JSReceiver> GetRoot(Isolate* isolate,
                                            Handle<Object> receiver,
                                            uint32_t index = kMaxUInt32) {
     if (receiver->IsJSReceiver()) return Handle<JSReceiver>::cast(receiver);
     return GetRootForNonJSReceiver(isolate, receiver, index);
   }
@@ skipping 15 matching lines @@
   const Handle<JSReceiver> initial_holder_;
   const uint32_t index_;
   uint32_t number_;
 };
 
 
 }  // namespace internal
 }  // namespace v8
 
 #endif  // V8_LOOKUP_H_