src/crankshaft/hydrogen.cc - Issue 1975763002: [runtime] Make sure that LookupIterator::OWN always performs a HIDDEN lookup as well.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/crankshaft/hydrogen.cc

Issue 1975763002: [runtime] Make sure that LookupIterator::OWN always performs a HIDDEN lookup as well. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Addressed comment Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/crankshaft/hydrogen.cc

diff --git a/src/crankshaft/hydrogen.cc b/src/crankshaft/hydrogen.cc

index 67b7540475bec3f10295a0b978a20629b6ca07b7..33f58d1e4492323489418c668af383b167631925 100644

--- a/src/crankshaft/hydrogen.cc

+++ b/src/crankshaft/hydrogen.cc

@@ -5774,6 +5774,7 @@ HOptimizedGraphBuilder::LookupGlobalProperty(Variable* var, LookupIterator* it,

return kUseGeneric;

case LookupIterator::DATA:

if (access_type == STORE && it->IsReadOnly()) return kUseGeneric;

+ if (!it->GetHolder<JSObject>()->IsJSGlobalObject()) return kUseGeneric;

return kUseCell;

case LookupIterator::JSPROXY:

case LookupIterator::TRANSITION:

« no previous file with comments | « src/compiler/js-global-object-specialization.cc ('k') | src/ic/ic.cc » ('j') | no next file with comments »