Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(653)

Side by Side Diff: src/crankshaft/hydrogen.cc

Issue 1975763002: [runtime] Make sure that LookupIterator::OWN always performs a HIDDEN lookup as well. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Addressed comment Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/compiler/js-global-object-specialization.cc ('k') | src/ic/ic.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/crankshaft/hydrogen.h" 5 #include "src/crankshaft/hydrogen.h"
6 6
7 #include <sstream> 7 #include <sstream>
8 8
9 #include "src/allocation-site-scopes.h" 9 #include "src/allocation-site-scopes.h"
10 #include "src/ast/ast-numbering.h" 10 #include "src/ast/ast-numbering.h"
(...skipping 5756 matching lines...) Expand 10 before | Expand all | Expand 10 after
5767 5767
5768 switch (it->state()) { 5768 switch (it->state()) {
5769 case LookupIterator::ACCESSOR: 5769 case LookupIterator::ACCESSOR:
5770 case LookupIterator::ACCESS_CHECK: 5770 case LookupIterator::ACCESS_CHECK:
5771 case LookupIterator::INTERCEPTOR: 5771 case LookupIterator::INTERCEPTOR:
5772 case LookupIterator::INTEGER_INDEXED_EXOTIC: 5772 case LookupIterator::INTEGER_INDEXED_EXOTIC:
5773 case LookupIterator::NOT_FOUND: 5773 case LookupIterator::NOT_FOUND:
5774 return kUseGeneric; 5774 return kUseGeneric;
5775 case LookupIterator::DATA: 5775 case LookupIterator::DATA:
5776 if (access_type == STORE && it->IsReadOnly()) return kUseGeneric; 5776 if (access_type == STORE && it->IsReadOnly()) return kUseGeneric;
5777 if (!it->GetHolder<JSObject>()->IsJSGlobalObject()) return kUseGeneric;
5777 return kUseCell; 5778 return kUseCell;
5778 case LookupIterator::JSPROXY: 5779 case LookupIterator::JSPROXY:
5779 case LookupIterator::TRANSITION: 5780 case LookupIterator::TRANSITION:
5780 UNREACHABLE(); 5781 UNREACHABLE();
5781 } 5782 }
5782 UNREACHABLE(); 5783 UNREACHABLE();
5783 return kUseGeneric; 5784 return kUseGeneric;
5784 } 5785 }
5785 5786
5786 5787
(...skipping 7958 matching lines...) Expand 10 before | Expand all | Expand 10 after
13745 isolate()->GetHTracer()->TraceHydrogen(name(), graph_); 13746 isolate()->GetHTracer()->TraceHydrogen(name(), graph_);
13746 } 13747 }
13747 13748
13748 #ifdef DEBUG 13749 #ifdef DEBUG
13749 graph_->Verify(false); // No full verify. 13750 graph_->Verify(false); // No full verify.
13750 #endif 13751 #endif
13751 } 13752 }
13752 13753
13753 } // namespace internal 13754 } // namespace internal
13754 } // namespace v8 13755 } // namespace v8
OLDNEW
« no previous file with comments | « src/compiler/js-global-object-specialization.cc ('k') | src/ic/ic.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698