Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(417)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 197533008: Mac: ExternalPopupMenu::close should hide a showing popup menu. (Closed)

Created:
6 years, 9 months ago by tkent
Modified:
6 years, 9 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, nasko+codewatch_chromium.org, jam, creis+watch_chromium.org
Visibility:
Public.

Description

Mac: ExternalPopupMenu::close should hide a showing popup menu. * This CL introduces new IPC message to tell a request to hide a SELECT popup menu. * We need to clear RenderViewImpl::external_popup_menu_ immediately after sending the IPC message. Without it, following popup menu requests will fail because of existence of non-null external_popup_menu_. It causes some layout test failures. BUG=30550, 145658 R=avi@chromium.org, rsesek@chromium.org, tsepez@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=258856

Patch Set 1 : #

Total comments: 2

Patch Set 2 : alignment #

Total comments: 8

Patch Set 3 : apply comments #

Total comments: 2

Patch Set 4 : test fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+109 lines, -28 lines) Patch
M content/browser/frame_host/interstitial_page_impl.cc View 2 chunks +5 lines, -0 lines 0 comments Download
M content/browser/renderer_host/popup_menu_helper_mac.h View 1 2 3 chunks +9 lines, -1 line 0 comments Download
M content/browser/renderer_host/popup_menu_helper_mac.mm View 1 2 3 chunks +26 lines, -13 lines 0 comments Download
M content/browser/renderer_host/render_view_host_impl.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/renderer_host/render_view_host_impl.cc View 1 2 2 chunks +7 lines, -0 lines 0 comments Download
M content/browser/renderer_host/render_view_host_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/renderer_host/webmenurunner_mac.h View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M content/browser/renderer_host/webmenurunner_mac.mm View 1 chunk +4 lines, -0 lines 0 comments Download
M content/browser/web_contents/web_contents_view_android.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/web_contents/web_contents_view_android.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M content/browser/web_contents/web_contents_view_aura.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/web_contents/web_contents_view_aura.cc View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
M content/browser/web_contents/web_contents_view_guest.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/web_contents/web_contents_view_guest.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M content/browser/web_contents/web_contents_view_mac.h View 3 chunks +4 lines, -0 lines 0 comments Download
M content/browser/web_contents/web_contents_view_mac.mm View 1 chunk +11 lines, -4 lines 0 comments Download
M content/common/view_messages.h View 1 2 1 chunk +3 lines, -1 line 0 comments Download
M content/port/browser/render_view_host_delegate_view.h View 1 chunk +3 lines, -0 lines 0 comments Download
M content/renderer/external_popup_menu.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M content/renderer/render_view_impl.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/render_view_impl.cc View 1 2 3 2 chunks +7 lines, -7 lines 0 comments Download
M content/test/test_web_contents_view.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/test/test_web_contents_view.cc View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 24 (0 generated)
tkent
jcivelli@, avi@, would you review Obj-C part of this CL please?
6 years, 9 months ago (2014-03-19 06:45:34 UTC) #1
Avi (use Gerrit)
This LGTM. A minor formatting nit is all. https://codereview.chromium.org/197533008/diff/40001/content/browser/renderer_host/popup_menu_helper_mac.mm File content/browser/renderer_host/popup_menu_helper_mac.mm (right): https://codereview.chromium.org/197533008/diff/40001/content/browser/renderer_host/popup_menu_helper_mac.mm#newcode78 content/browser/renderer_host/popup_menu_helper_mac.mm:78: initialIndex:selected_item]; ...
6 years, 9 months ago (2014-03-19 14:36:19 UTC) #2
tkent
avi@, is it ok for the whole content/? nasko@, would you review view_messages.h please? https://codereview.chromium.org/197533008/diff/40001/content/browser/renderer_host/popup_menu_helper_mac.mm ...
6 years, 9 months ago (2014-03-20 05:21:14 UTC) #3
Avi (use Gerrit)
Yes, I <3 what you did for all of content/.
6 years, 9 months ago (2014-03-20 14:29:28 UTC) #4
Robert Sesek
Some drive-by comments. https://codereview.chromium.org/197533008/diff/50001/content/browser/renderer_host/popup_menu_helper_mac.mm File content/browser/renderer_host/popup_menu_helper_mac.mm (right): https://codereview.chromium.org/197533008/diff/50001/content/browser/renderer_host/popup_menu_helper_mac.mm#newcode28 content/browser/renderer_host/popup_menu_helper_mac.mm:28: : render_view_host_(static_cast<RenderViewHostImpl*>(render_view_host)), menu_runner_ is uninitialized here. ...
6 years, 9 months ago (2014-03-20 15:06:04 UTC) #5
tkent
rsesek, thank you for the comments. https://codereview.chromium.org/197533008/diff/50001/content/browser/renderer_host/popup_menu_helper_mac.mm File content/browser/renderer_host/popup_menu_helper_mac.mm (right): https://codereview.chromium.org/197533008/diff/50001/content/browser/renderer_host/popup_menu_helper_mac.mm#newcode28 content/browser/renderer_host/popup_menu_helper_mac.mm:28: : render_view_host_(static_cast<RenderViewHostImpl*>(render_view_host)), On ...
6 years, 9 months ago (2014-03-21 13:55:26 UTC) #6
tkent
Add more security guys for content/common/view_messages.h. Can anyone approve it?
6 years, 9 months ago (2014-03-21 13:56:53 UTC) #7
inferno
6 years, 9 months ago (2014-03-21 14:09:18 UTC) #8
Tom Sepez
Messages LGTM https://codereview.chromium.org/197533008/diff/70001/content/common/view_messages.h File content/common/view_messages.h (right): https://codereview.chromium.org/197533008/diff/70001/content/common/view_messages.h#newcode1205 content/common/view_messages.h:1205: // Message to show/hide a popup menu ...
6 years, 9 months ago (2014-03-21 18:05:28 UTC) #9
tkent
Thank you for reviewing. https://codereview.chromium.org/197533008/diff/70001/content/common/view_messages.h File content/common/view_messages.h (right): https://codereview.chromium.org/197533008/diff/70001/content/common/view_messages.h#newcode1205 content/common/view_messages.h:1205: // Message to show/hide a ...
6 years, 9 months ago (2014-03-22 14:00:14 UTC) #10
tkent
The CQ bit was checked by tkent@chromium.org
6 years, 9 months ago (2014-03-22 14:00:19 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tkent@chromium.org/197533008/70001
6 years, 9 months ago (2014-03-22 14:00:24 UTC) #12
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-22 15:05:55 UTC) #13
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=286495
6 years, 9 months ago (2014-03-22 15:05:55 UTC) #14
tkent
The CQ bit was checked by tkent@chromium.org
6 years, 9 months ago (2014-03-22 15:14:44 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tkent@chromium.org/197533008/70001
6 years, 9 months ago (2014-03-22 15:14:54 UTC) #16
tkent
The CQ bit was unchecked by tkent@chromium.org
6 years, 9 months ago (2014-03-22 16:52:04 UTC) #17
tkent
The CQ bit was checked by tkent@chromium.org
6 years, 9 months ago (2014-03-22 16:58:56 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tkent@chromium.org/197533008/90001
6 years, 9 months ago (2014-03-22 16:59:00 UTC) #19
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-22 18:23:10 UTC) #20
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on linux_chromium_rel
6 years, 9 months ago (2014-03-22 18:23:11 UTC) #21
tkent
The CQ bit was checked by tkent@chromium.org
6 years, 9 months ago (2014-03-22 22:48:50 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tkent@chromium.org/197533008/90001
6 years, 9 months ago (2014-03-22 22:48:56 UTC) #23
commit-bot: I haz the power
6 years, 9 months ago (2014-03-24 02:59:42 UTC) #24
Message was sent while issue was closed. 
Change committed as 258856

Powered by Google App Engine
This is Rietveld 408576698