content/browser/renderer_host/webmenurunner_mac.mm - Issue 197533008: Mac: ExternalPopupMenu::close should hide a showing popup menu.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/webmenurunner_mac.mm

Issue 197533008: Mac: ExternalPopupMenu::close should hide a showing popup menu. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: test fix Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/renderer_host/webmenurunner_mac.mm

diff --git a/content/browser/renderer_host/webmenurunner_mac.mm b/content/browser/renderer_host/webmenurunner_mac.mm

index bb33a007aa6b6b2fa8ee5fde498d569fef725a2c..94e77453e9181155ee6fc1cf7c52fd6938ffc786 100644

--- a/content/browser/renderer_host/webmenurunner_mac.mm

+++ b/content/browser/renderer_host/webmenurunner_mac.mm

@@ -148,6 +148,10 @@

index_ = [cell indexOfSelectedItem];

}

+- (void)hide {

+ [menu_ cancelTracking];

- (int)indexOfSelectedItem {

return index_;

}