content/renderer/external_popup_menu.cc - Issue 197533008: Mac: ExternalPopupMenu::close should hide a showing popup menu.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/external_popup_menu.cc

Issue 197533008: Mac: ExternalPopupMenu::close should hide a showing popup menu. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: test fix Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/renderer/external_popup_menu.cc

diff --git a/content/renderer/external_popup_menu.cc b/content/renderer/external_popup_menu.cc

index 019091313412ded4b1cad583b4428445fd5de771..a1bb2475b73b01c0050aeb075aa27639f3302bee 100644

--- a/content/renderer/external_popup_menu.cc

+++ b/content/renderer/external_popup_menu.cc

@@ -54,8 +54,9 @@ void ExternalPopupMenu::show(const blink::WebRect& bounds) {

}

void ExternalPopupMenu::close() {

- popup_menu_client_ = NULL;

- render_view_ = NULL;

+ render_view_->Send(new ViewHostMsg_HidePopup(render_view_->routing_id()));

+ render_view_->DidHideExternalPopupMenu();

+ // |this| was deleted.

}

#if defined(OS_MACOSX)