Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(244)

Issue 1974903002: [arm] Clean up handling of usat. (Closed)

Created:
4 years, 7 months ago by jbramley
Modified:
4 years, 7 months ago
Reviewers:
Benedikt Meurer, Jarin
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-ppc-ports_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[arm] Clean up handling of usat. The usat instruction is available from ARMv6, so there's no need to check for the ARMv7 feature before using it. ARMv6 is the oldest supported architecture in V8. Correcting this allows the removal of a special case for predictable code size. BUG= Committed: https://crrev.com/83b9e1bee417919c2a9299bf4a8e176398bb021c Cr-Commit-Position: refs/heads/master@{#36218}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -65 lines) Patch
M src/arm/assembler-arm.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/arm/macro-assembler-arm.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/arm/macro-assembler-arm.cc View 2 chunks +1 line, -32 lines 0 comments Download
M test/cctest/test-assembler-arm.cc View 1 chunk +17 lines, -20 lines 0 comments Download
M test/cctest/test-disasm-arm.cc View 2 chunks +9 lines, -9 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
jbramley
4 years, 7 months ago (2016-05-12 17:43:03 UTC) #2
Benedikt Meurer
Awesome cleanup. LGTM.
4 years, 7 months ago (2016-05-12 17:44:47 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1974903002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1974903002/1
4 years, 7 months ago (2016-05-12 17:46:27 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-12 18:18:30 UTC) #6
commit-bot: I haz the power
4 years, 7 months ago (2016-05-12 18:20:44 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/83b9e1bee417919c2a9299bf4a8e176398bb021c
Cr-Commit-Position: refs/heads/master@{#36218}

Powered by Google App Engine
This is Rietveld 408576698