Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1974833002:
Import quirks-mode tests (Closed)
DescriptionImport quirks-mode tests
Import quirks-mode tests and mark the failing tests in
TestExpectations for now.
BUG=611442
Committed: https://crrev.com/a6291c3ea84f371d10c0d10e66ee6d11458c9d42
Cr-Commit-Position: refs/heads/master@{#395325}
Committed: https://crrev.com/d74e226e0bc4ea9b4914af953d15f61ab5f4e5bb
Cr-Commit-Position: refs/heads/master@{#395577}
Patch Set 1 #Patch Set 2 : #Patch Set 3 : Fix patch error #Patch Set 4 : wpt rename #
Total comments: 4
Patch Set 5 : Address review comments #Patch Set 6 : Rebase #Patch Set 7 : Try to skip #Patch Set 8 : Add separate Release and Debug entries #Messages
Total messages: 58 (26 generated)
Description was changed from ========== Import quirks-mode tests that are passing Import quirks-mode tests that are passing BUG= ========== to ========== Import quirks-mode tests that are passing Import quirks-mode tests that are passing BUG=BUG=611442 ==========
Description was changed from ========== Import quirks-mode tests that are passing Import quirks-mode tests that are passing BUG=BUG=611442 ========== to ========== Import quirks-mode tests that are passing Import quirks-mode tests that are passing BUG=611442 ==========
Description was changed from ========== Import quirks-mode tests that are passing Import quirks-mode tests that are passing BUG=611442 ========== to ========== Import quirks-mode tests that are passing Import quirks-mode tests that we are passing today. BUG=611442 ==========
rob.buis@samsung.com changed reviewers: + rune@opera.com, timloh@chromium.org
PTAL. Obviously this one has to go in first, hence the redness: https://codereview.chromium.org/1963843002/ I figured we may as well import some more besides hashless-hex-color.html, but not the ones that currently fail (3 in total). Or is it preferred to import all and skip the failing ones for now?
timloh@chromium.org changed reviewers: + kojii@chromium.org
+kojii, who has done a bunch of test importing
kojii@chromium.org changed reviewers: + tkent@chromium.org
On 2016/05/13 at 01:32:44, timloh wrote: > +kojii, who has done a bunch of test importing +tkent, who manages and look over wpt imports. Copying files manually doesn't work, it will overwritten/removed on the next import script. You will need to add to W3CImportExpectations, then run the "update-w3c-deps wpt" script. Please find the following document for the details: http://www.chromium.org/blink/importing-the-w3c-tests If you imports and see failures, this document describes how to handles them: https://docs.google.com/document/d/1UkdKJYk-x2q3VkHqZDzRUyb281_OOIVpUb_LGxyWb...
Description was changed from ========== Import quirks-mode tests that are passing Import quirks-mode tests that we are passing today. BUG=611442 ========== to ========== Import quirks-mode tests Import quirks-mode tests. BUG=611442 ==========
Patchset #2 (id:20001) has been deleted
On 2016/05/13 05:55:36, kojii wrote: > On 2016/05/13 at 01:32:44, timloh wrote: > > +kojii, who has done a bunch of test importing > > +tkent, who manages and look over wpt imports. > > Copying files manually doesn't work, it will overwritten/removed on the next > import script. You will need to add to W3CImportExpectations, then run the > "update-w3c-deps wpt" script. Please find the following document for the > details: > http://www.chromium.org/blink/importing-the-w3c-tests > > If you imports and see failures, this document describes how to handles them: > https://docs.google.com/document/d/1UkdKJYk-x2q3VkHqZDzRUyb281_OOIVpUb_LGxyWb... Hi kojii, tkent. I started doing this but when running update-w3c-deps I got: # err> imported/wpt/webgl/conformance-1.0.3/conformance/glsl/misc/shader-with-non-reserved-words.html # err> imported/wpt/webgl/conformance-1.0.3/conformance/glsl/misc/embedded-struct-definitions-forbidden.html # err> imported/wpt/webgl/conformance-1.0.3/conformance/glsl/misc/non-ascii.vert.html # err> Traceback (most recent call last): .... Tools/Scripts/webkitpy/w3c/test_converter.py", line 50, in convert_for_webkit # err> converter.feed(contents.decode('utf-8')) # err> File "/usr/lib/python2.7/encodings/utf_8.py", line 16, in decode # err> return codecs.utf_8_decode(input, errors, True) # err> UnicodeDecodeError: 'utf8' codec can't decode byte 0x82 in position 1899: invalid start byte Is this a known problem?
+qyearsley On 2016/05/16 21:04:52, rwlbuis wrote: > Is this a known problem? We changed the import path from 'web-platform-tests' to 'wpt' in the importer script, but the files in the tree and the config file (LayoutTests/W3CImportExpectations) isn't updated yet so it doesn't "skip" anything, so you're hitting that error. http://crbug.com/611762 has a WIP fix.
On 2016/05/16 21:15:43, jsbell wrote: > +qyearsley > > On 2016/05/16 21:04:52, rwlbuis wrote: > > Is this a known problem? > > We changed the import path from 'web-platform-tests' to 'wpt' in the importer > script, but the files in the tree and the config file > (LayoutTests/W3CImportExpectations) isn't updated yet so it doesn't "skip" > anything, so you're hitting that error. > > http://crbug.com/611762 has a WIP fix. Thanks for letting me know! Right now the patch seems too big to handle, as in I don't think I can apply it locally. Anyway I'll track the progress and will retry later.
Description was changed from ========== Import quirks-mode tests Import quirks-mode tests. BUG=611442 ========== to ========== Import quirks-mode tests Import quirks-mode tests and mark the failing tests in LayoutTestExpectations for now. BUG=611442 ==========
Description was changed from ========== Import quirks-mode tests Import quirks-mode tests and mark the failing tests in LayoutTestExpectations for now. BUG=611442 ========== to ========== Import quirks-mode tests Import quirks-mode tests and mark the failing tests in TestExpectations for now. BUG=611442 ==========
@kojii, @tkent Because of the problems caused by the 'web-platform-tests' to 'wpt' transition I used the importer from a month old Blink checkout I have on my system. Could you have a look at the current patch?
On 2016/05/19 at 00:21:44, rob.buis wrote: > @kojii, @tkent > > Because of the problems caused by the 'web-platform-tests' to 'wpt' transition I used the importer from a month old Blink checkout I have on my system. Could you have a look at the current patch? Patch looks good. crbug.com/611762 looks like making progress, but needs to split patches due to a large change. I see lots of commits today, and it will probably conflict. Sorry for the trouble, hopefully it should be done in a day or two.
On 2016/05/19 at 03:34:29, kojii wrote: > On 2016/05/19 at 00:21:44, rob.buis wrote: > > @kojii, @tkent > > > > Because of the problems caused by the 'web-platform-tests' to 'wpt' transition I used the importer from a month old Blink checkout I have on my system. Could you have a look at the current patch? > > Patch looks good. > > crbug.com/611762 looks like making progress, but needs to split patches due to a large change. I see lots of commits today, and it will probably conflict. Sorry for the trouble, hopefully it should be done in a day or two. Looks good to me too, and sorry for the trouble with the move -- I think that this CL might actually be able to landed before that finishes though (although there may be some conflict in W3CImportExpectations)
https://codereview.chromium.org/1974833002/diff/80001/third_party/WebKit/Layo... File third_party/WebKit/LayoutTests/TestExpectations (right): https://codereview.chromium.org/1974833002/diff/80001/third_party/WebKit/Layo... third_party/WebKit/LayoutTests/TestExpectations:1403: crbug.com/490511 imported/wpt/quirks-mode/percentage-height-calculation.html [ Failure ] I don't think 490511 is an appropriate bug for this. This is an issue of css/layout areas. https://codereview.chromium.org/1974833002/diff/80001/third_party/WebKit/Layo... File third_party/WebKit/LayoutTests/W3CImportExpectations (right): https://codereview.chromium.org/1974833002/diff/80001/third_party/WebKit/Layo... third_party/WebKit/LayoutTests/W3CImportExpectations:261: # imported/web-platform-tests/quirks-mode [ Skip ] Needs an owner line like: ## Owners: rob.buis@samsung.com
PTAL. https://codereview.chromium.org/1974833002/diff/80001/third_party/WebKit/Layo... File third_party/WebKit/LayoutTests/TestExpectations (right): https://codereview.chromium.org/1974833002/diff/80001/third_party/WebKit/Layo... third_party/WebKit/LayoutTests/TestExpectations:1403: crbug.com/490511 imported/wpt/quirks-mode/percentage-height-calculation.html [ Failure ] On 2016/05/19 22:59:54, tkent wrote: > I don't think 490511 is an appropriate bug for this. This is an issue of > css/layout areas. Ok, I made three separate bugs in my latest patch. https://codereview.chromium.org/1974833002/diff/80001/third_party/WebKit/Layo... File third_party/WebKit/LayoutTests/W3CImportExpectations (right): https://codereview.chromium.org/1974833002/diff/80001/third_party/WebKit/Layo... third_party/WebKit/LayoutTests/W3CImportExpectations:261: # imported/web-platform-tests/quirks-mode [ Skip ] On 2016/05/19 22:59:54, tkent wrote: > Needs an owner line like: > ## Owners: mailto:rob.buis@samsung.com Done.
lgtm
The CQ bit was checked by rob.buis@samsung.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1974833002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1974833002/100001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: ios-device on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...) ios-simulator on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...) mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by rob.buis@samsung.com
The patchset sent to the CQ was uploaded after l-g-t-m from tkent@chromium.org Link to the patchset: https://codereview.chromium.org/1974833002/#ps120001 (title: "Rebase")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1974833002/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1974833002/120001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by rob.buis@samsung.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1974833002/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1974833002/120001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by rob.buis@samsung.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1974833002/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1974833002/120001
Message was sent while issue was closed.
Description was changed from ========== Import quirks-mode tests Import quirks-mode tests and mark the failing tests in TestExpectations for now. BUG=611442 ========== to ========== Import quirks-mode tests Import quirks-mode tests and mark the failing tests in TestExpectations for now. BUG=611442 ==========
Message was sent while issue was closed.
Committed patchset #6 (id:120001)
Message was sent while issue was closed.
Description was changed from ========== Import quirks-mode tests Import quirks-mode tests and mark the failing tests in TestExpectations for now. BUG=611442 ========== to ========== Import quirks-mode tests Import quirks-mode tests and mark the failing tests in TestExpectations for now. BUG=611442 Committed: https://crrev.com/a6291c3ea84f371d10c0d10e66ee6d11458c9d42 Cr-Commit-Position: refs/heads/master@{#395325} ==========
Message was sent while issue was closed.
Patchset 6 (id:??) landed as https://crrev.com/a6291c3ea84f371d10c0d10e66ee6d11458c9d42 Cr-Commit-Position: refs/heads/master@{#395325}
Message was sent while issue was closed.
A revert of this CL (patchset #6 id:120001) has been created in https://codereview.chromium.org/2007683002/ by mek@chromium.org. The reason for reverting is: Not sure why the TestExpectations aren't working, but this is causing failures on the WebKit Win7 dbg bot: https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win7%20%28dbg%... 11:01:42.789 4692 worker/1 imported/wpt/quirks-mode/hashless-hex-color.html output stderr lines: 11:01:42.789 4692 [5292:4872:0523/110125:6137438:ERROR:service_registry_impl.cc(95)] blink::mojom::VRService not found 11:01:42.789 4916 [2/2] imported/wpt/quirks-mode/hashless-hex-color.html failed unexpectedly (test timed out).
Message was sent while issue was closed.
Description was changed from ========== Import quirks-mode tests Import quirks-mode tests and mark the failing tests in TestExpectations for now. BUG=611442 Committed: https://crrev.com/a6291c3ea84f371d10c0d10e66ee6d11458c9d42 Cr-Commit-Position: refs/heads/master@{#395325} ========== to ========== Import quirks-mode tests Import quirks-mode tests and mark the failing tests in TestExpectations for now. BUG=611442 Committed: https://crrev.com/a6291c3ea84f371d10c0d10e66ee6d11458c9d42 Cr-Commit-Position: refs/heads/master@{#395325} ==========
On 2016/05/23 at 20:15:16, mek wrote: > The reason for reverting is: Not sure why the TestExpectations aren't working, but this is causing failures on the WebKit Win7 dbg bot: > > https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win7%20%28dbg%... > > 11:01:42.789 4692 worker/1 imported/wpt/quirks-mode/hashless-hex-color.html output stderr lines: > 11:01:42.789 4692 [5292:4872:0523/110125:6137438:ERROR:service_registry_impl.cc(95)] blink::mojom::VRService not found > 11:01:42.789 4916 [2/2] imported/wpt/quirks-mode/hashless-hex-color.html failed unexpectedly (test timed out). In this case, we should add a [ Timeout ] TestExpectation entry. [ Failure ] doesn't include Timeout and Crash.
On 2016/05/23 21:18:30, tkent wrote: > On 2016/05/23 at 20:15:16, mek wrote: > > The reason for reverting is: Not sure why the TestExpectations aren't working, > but this is causing failures on the WebKit Win7 dbg bot: > > > > > https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win7%20%28dbg%... > > > > 11:01:42.789 4692 worker/1 imported/wpt/quirks-mode/hashless-hex-color.html > output stderr lines: > > 11:01:42.789 4692 > [5292:4872:0523/110125:6137438:ERROR:service_registry_impl.cc(95)] > blink::mojom::VRService not found > > 11:01:42.789 4916 [2/2] imported/wpt/quirks-mode/hashless-hex-color.html > failed unexpectedly (test timed out). > > In this case, we should add a [ Timeout ] TestExpectation entry. [ Failure ] > doesn't include Timeout and Crash. Hi tkent, do you mean a [ Failure Timeout ] entry? Or just a [ Timeout ] ?
On 2016/05/23 at 21:28:51, rob.buis wrote: > > In this case, we should add a [ Timeout ] TestExpectation entry. [ Failure ] > > doesn't include Timeout and Crash. > > Hi tkent, do you mean a [ Failure Timeout ] entry? Or just a [ Timeout ] ? According to the dashboard, - Text failure on Release build - Text failure or Timeout on Debug build So, we should have two entries like: crbug.com/611442 [ Release ] imported/wpt/quirks-mode/hashless-hex-color.html [ Failure ] crbug.com/611442 [ Debug ] imported/wpt/quirks-mode/hashless-hex-color.html [ Failure Timeout ] http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=has...
On 2016/05/23 22:53:45, tkent wrote: > According to the dashboard, > - Text failure on Release build > - Text failure or Timeout on Debug build > > So, we should have two entries like: > > crbug.com/611442 [ Release ] imported/wpt/quirks-mode/hashless-hex-color.html [ > Failure ] > crbug.com/611442 [ Debug ] imported/wpt/quirks-mode/hashless-hex-color.html [ > Failure Timeout ] > > > http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=has... Thanks, that makes sense. I implemented it in patch set 8.
lgtm
The CQ bit was checked by rob.buis@samsung.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1974833002/160001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1974833002/160001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
The CQ bit was checked by rob.buis@samsung.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1974833002/160001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1974833002/160001
Message was sent while issue was closed.
Description was changed from ========== Import quirks-mode tests Import quirks-mode tests and mark the failing tests in TestExpectations for now. BUG=611442 Committed: https://crrev.com/a6291c3ea84f371d10c0d10e66ee6d11458c9d42 Cr-Commit-Position: refs/heads/master@{#395325} ========== to ========== Import quirks-mode tests Import quirks-mode tests and mark the failing tests in TestExpectations for now. BUG=611442 Committed: https://crrev.com/a6291c3ea84f371d10c0d10e66ee6d11458c9d42 Cr-Commit-Position: refs/heads/master@{#395325} ==========
Message was sent while issue was closed.
Committed patchset #8 (id:160001)
Message was sent while issue was closed.
Description was changed from ========== Import quirks-mode tests Import quirks-mode tests and mark the failing tests in TestExpectations for now. BUG=611442 Committed: https://crrev.com/a6291c3ea84f371d10c0d10e66ee6d11458c9d42 Cr-Commit-Position: refs/heads/master@{#395325} ========== to ========== Import quirks-mode tests Import quirks-mode tests and mark the failing tests in TestExpectations for now. BUG=611442 Committed: https://crrev.com/a6291c3ea84f371d10c0d10e66ee6d11458c9d42 Cr-Commit-Position: refs/heads/master@{#395325} Committed: https://crrev.com/d74e226e0bc4ea9b4914af953d15f61ab5f4e5bb Cr-Commit-Position: refs/heads/master@{#395577} ==========
Message was sent while issue was closed.
Patchset 8 (id:??) landed as https://crrev.com/d74e226e0bc4ea9b4914af953d15f61ab5f4e5bb Cr-Commit-Position: refs/heads/master@{#395577} |
