Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(310)

Issue 2007683002: Revert of Import quirks-mode tests (Closed)

Created:
4 years, 7 months ago by Marijn Kruisselbrink
Modified:
4 years, 7 months ago
CC:
blink-reviews, blink-reviews-w3ctests_chromium.org, chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Import quirks-mode tests (patchset #6 id:120001 of https://codereview.chromium.org/1974833002/ ) Reason for revert: Not sure why the TestExpectations aren't working, but this is causing failures on the WebKit Win7 dbg bot: https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win7%20%28dbg%29/builds/5742 11:01:42.789 4692 worker/1 imported/wpt/quirks-mode/hashless-hex-color.html output stderr lines: 11:01:42.789 4692 [5292:4872:0523/110125:6137438:ERROR:service_registry_impl.cc(95)] blink::mojom::VRService not found 11:01:42.789 4916 [2/2] imported/wpt/quirks-mode/hashless-hex-color.html failed unexpectedly (test timed out) Original issue's description: > Import quirks-mode tests > > Import quirks-mode tests and mark the failing tests in > TestExpectations for now. > > BUG=611442 > > Committed: https://crrev.com/a6291c3ea84f371d10c0d10e66ee6d11458c9d42 > Cr-Commit-Position: refs/heads/master@{#395325} TBR=tkent@chromium.org,kojii@chromium.org,rune@opera.com,timloh@chromium.org,rob.buis@samsung.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=611442 Committed: https://crrev.com/9333d231ceae728f850edf4e3c0241642467c1d0 Cr-Commit-Position: refs/heads/master@{#395399}

Patch Set 1 #

Messages

Total messages: 6 (1 generated)
Marijn Kruisselbrink
Created Revert of Import quirks-mode tests
4 years, 7 months ago (2016-05-23 20:15:16 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2007683002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2007683002/1
4 years, 7 months ago (2016-05-23 20:15:36 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-23 20:16:28 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/9333d231ceae728f850edf4e3c0241642467c1d0 Cr-Commit-Position: refs/heads/master@{#395399}
4 years, 7 months ago (2016-05-23 20:18:15 UTC) #5
tkent
4 years, 7 months ago (2016-05-23 21:19:02 UTC) #6
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698