Implement DBus changes needed for notifications.

Implement DBus changes needed for notifications.

This implements the code we need to be able to receive the start notifications
and stop notifications calls from BlueZ and the rest of the code needed to
send a value update notification to BlueZ.

This is part 1 of 2 CLs.
https://codereview.chromium.org/1974633002 <<<
https://codereview.chromium.org/1973703002

R=xiyuan@chromium.org
BUG=610393
Committed: https://crrev.com/1cd8d446e0fb6a9aea498c604967305ef8033688
Cr-Commit-Position: refs/heads/master@{#393382}

[rkc, 2016-05-12 04:10:09]

Description was changed from

==========
Implement DBus changes needed for notifications.

This implements the code we need to be able to receive the start notifications
and stop notifications calls from BlueZ and the rest of the code needed to
send a value update notification to BlueZ.

This is part 1 of a 2 CLs.

R=xiyuan@chromium.org
BUG=610393
==========

to

==========
Implement DBus changes needed for notifications.

This implements the code we need to be able to receive the start notifications
and stop notifications calls from BlueZ and the rest of the code needed to
send a value update notification to BlueZ.

This is part 1 of 2 CLs.
https://codereview.chromium.org/1974633002 <<<
https://codereview.chromium.org/1973703002

R=xiyuan@chromium.org
BUG=610393
==========

[xiyuan, 2016-05-12 18:33:18]

https://codereview.chromium.org/1974633002/diff/1/device/bluetooth/dbus/bluet...
File
device/bluetooth/dbus/bluetooth_gatt_characteristic_service_provider_impl.cc
(right):

https://codereview.chromium.org/1974633002/diff/1/device/bluetooth/dbus/bluet...
device/bluetooth/dbus/bluetooth_gatt_characteristic_service_provider_impl.cc:377:
void BluetoothGattCharacteristicServiceProviderImpl::StartNotify(
Silly question: Why StartNotify do delegate_->GetValue and StopNotify do
delegate_->SetValue ?

It does not look like what I saw from bluez doc:
https://kernel.googlesource.com/pub/scm/bluetooth/bluez/+/master/doc/gatt-api...

It seems StartNotify should not return anything and StopNotify does not have any
input.

https://codereview.chromium.org/1974633002/diff/1/device/bluetooth/dbus/bluet...
device/bluetooth/dbus/bluetooth_gatt_characteristic_service_provider_impl.cc:394:
VLOG(3) << "BluetoothGattCharacteristicServiceProvider::WriteValue: "
nit: update the message, WriteValue -> StopNotify?

https://codereview.chromium.org/1974633002/diff/1/device/bluetooth/dbus/bluet...
device/bluetooth/dbus/bluetooth_gatt_characteristic_service_provider_impl.cc:403:
VLOG(2) << "Error reading array of bytes in in WriteValue";
nit: update the message

[rkc, 2016-05-12 19:51:50]

https://codereview.chromium.org/1974633002/diff/1/device/bluetooth/dbus/bluet...
File
device/bluetooth/dbus/bluetooth_gatt_characteristic_service_provider_impl.cc
(right):

https://codereview.chromium.org/1974633002/diff/1/device/bluetooth/dbus/bluet...
device/bluetooth/dbus/bluetooth_gatt_characteristic_service_provider_impl.cc:377:
void BluetoothGattCharacteristicServiceProviderImpl::StartNotify(
On 2016/05/12 18:33:18, xiyuan wrote:
> Silly question: Why StartNotify do delegate_->GetValue and StopNotify do
> delegate_->SetValue ?
> 
> It does not look like what I saw from bluez doc:
>
https://kernel.googlesource.com/pub/scm/bluetooth/bluez/+/master/doc/gatt-api...
> 
> It seems StartNotify should not return anything and StopNotify does not have
any
> input.

Ugh, this is really stupid of me. I apologize! This is of course, all wrong. I
copy/pasted the code from ReadValue/WriteValue and completely forgot to change
the actual implementation.

This is why we need end-to-end tests. :-\

Fixed.

https://codereview.chromium.org/1974633002/diff/1/device/bluetooth/dbus/bluet...
device/bluetooth/dbus/bluetooth_gatt_characteristic_service_provider_impl.cc:394:
VLOG(3) << "BluetoothGattCharacteristicServiceProvider::WriteValue: "
On 2016/05/12 18:33:18, xiyuan wrote:
> nit: update the message, WriteValue -> StopNotify?

Done.

https://codereview.chromium.org/1974633002/diff/1/device/bluetooth/dbus/bluet...
device/bluetooth/dbus/bluetooth_gatt_characteristic_service_provider_impl.cc:403:
VLOG(2) << "Error reading array of bytes in in WriteValue";
On 2016/05/12 18:33:18, xiyuan wrote:
> nit: update the message

Done.

[xiyuan, 2016-05-12 20:58:43]

lgtm

[rkc, 2016-05-12 21:42:36]

The CQ bit was checked by rkc@chromium.org

[commit-bot: I haz the power, 2016-05-12 21:43:11]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1974633002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1974633002/20001

[commit-bot: I haz the power, 2016-05-12 22:43:28]

Description was changed from

==========
Implement DBus changes needed for notifications.

This implements the code we need to be able to receive the start notifications
and stop notifications calls from BlueZ and the rest of the code needed to
send a value update notification to BlueZ.

This is part 1 of 2 CLs.
https://codereview.chromium.org/1974633002 <<<
https://codereview.chromium.org/1973703002

R=xiyuan@chromium.org
BUG=610393
==========

to

==========
Implement DBus changes needed for notifications.

This implements the code we need to be able to receive the start notifications
and stop notifications calls from BlueZ and the rest of the code needed to
send a value update notification to BlueZ.

This is part 1 of 2 CLs.
https://codereview.chromium.org/1974633002 <<<
https://codereview.chromium.org/1973703002

R=xiyuan@chromium.org
BUG=610393
==========

[commit-bot: I haz the power, 2016-05-12 22:43:30]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-05-12 22:46:04]

Description was changed from

==========
Implement DBus changes needed for notifications.

This implements the code we need to be able to receive the start notifications
and stop notifications calls from BlueZ and the rest of the code needed to
send a value update notification to BlueZ.

This is part 1 of 2 CLs.
https://codereview.chromium.org/1974633002 <<<
https://codereview.chromium.org/1973703002

R=xiyuan@chromium.org
BUG=610393
==========

to

==========
Implement DBus changes needed for notifications.

This implements the code we need to be able to receive the start notifications
and stop notifications calls from BlueZ and the rest of the code needed to
send a value update notification to BlueZ.

This is part 1 of 2 CLs.
https://codereview.chromium.org/1974633002 <<<
https://codereview.chromium.org/1973703002

R=xiyuan@chromium.org
BUG=610393

Committed: https://crrev.com/1cd8d446e0fb6a9aea498c604967305ef8033688
Cr-Commit-Position: refs/heads/master@{#393382}
==========

[commit-bot: I haz the power, 2016-05-12 22:46:05]

Patchset 2 (id:??) landed as
https://crrev.com/1cd8d446e0fb6a9aea498c604967305ef8033688
Cr-Commit-Position: refs/heads/master@{#393382}