device/bluetooth/dbus/bluetooth_gatt_service_service_provider_impl.cc - Issue 1974633002: Implement DBus changes needed for notifications.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: device/bluetooth/dbus/bluetooth_gatt_service_service_provider_impl.cc

Issue 1974633002: Implement DBus changes needed for notifications. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « device/bluetooth/dbus/bluetooth_gatt_service_service_provider_impl.h ('k') | device/bluetooth/dbus/fake_bluetooth_gatt_application_service_provider.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: device/bluetooth/dbus/bluetooth_gatt_service_service_provider_impl.cc

diff --git a/device/bluetooth/dbus/bluetooth_gatt_service_service_provider_impl.cc b/device/bluetooth/dbus/bluetooth_gatt_service_service_provider_impl.cc

index 0937aba1da9572dd1467d545cf967927ab6e224a..210dfc27fbc071109e7a9db821d7c1d2a04c1d6d 100644

--- a/device/bluetooth/dbus/bluetooth_gatt_service_service_provider_impl.cc

+++ b/device/bluetooth/dbus/bluetooth_gatt_service_service_provider_impl.cc

@@ -34,9 +34,6 @@ BluetoothGattServiceServiceProviderImpl::

weak_ptr_factory_(this) {

VLOG(1) << "Creating Bluetooth GATT service: " << object_path_.value()

<< " UUID: " << uuid;

- // If we have a null bus, this means that this is being initialized for a

- // test, hence we shouldn't do any other setup.

if (!bus_)

return;