Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Issue 1974143002: Revert of Generate separate files for union type containers (Closed)

Created:
4 years, 7 months ago by bashi
Modified:
4 years, 7 months ago
CC:
chromium-reviews, shans, tzik, johnme+watch_chromium.org, dshwang, eae+blinkwatch, fs, eric.carlson_apple.com, scheib+watch_chromium.org, apavlov+blink_chromium.org, rwlbuis, jsbell+serviceworker_chromium.org, mvanouwerkerk+watch_chromium.org, yhirano+watch_chromium.org, blink-reviews-css, blink-reviews-html_chromium.org, Justin Novosad, blink-reviews-dom_chromium.org, dglazkov+blink, Rik, blink-reviews-bindings_chromium.org, blink-reviews, harkness+watch_chromium.org, mcasas+watch+mediastream_chromium.org, Eric Willigers, nessy, rjwright, blink-reviews-style_chromium.org, serviceworker-reviews, Peter Beverloo, sof, nhiroki, feature-media-reviews_chromium.org, tommyw+watchlist_chromium.org, darktears, jsbell+idb_chromium.org, vcarbune.chromium, michaeln, tyoshino+watch_chromium.org, ajuma+watch-canvas_chromium.org, blink-reviews-animation_chromium.org, horo+watch_chromium.org, gasubic, falken, mlamouri+watch-blink_chromium.org, kinuko+serviceworker, cmumford, ortuno+watch_chromium.org, kinuko+fileapi, jshin+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Generate separate files for union type containers (patchset #4 id:60001 of https://codereview.chromium.org/1961883002/ ) Reason for revert: Broke win build Original issue's description: > Generate separate files for union type containers > > Generating union type containers into single files (per component) > is the root cause of cyclic dependencies when we use union types > with IDL dictionaries. We should put generated containers into > separate files. > > Unfortunately this CL brings a burden on developers. > See IDLUnionTypes.md for more details. > > BUG=524424 > > CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel > > Committed: https://crrev.com/89853fd3c7589e801151a70687beb391195cee9a > Cr-Commit-Position: refs/heads/master@{#393130} TBR=haraken@chromium.org,tasak@google.com,yukishiino@chromium.org,sebmarchand@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=524424 Committed: https://crrev.com/86c39ef8dc835af7cdef08020fa9d80eb1d9078d Cr-Commit-Position: refs/heads/master@{#393389}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3038 lines, -3807 lines) Patch
D third_party/WebKit/Source/bindings/IDLUnionTypes.md View 1 chunk +0 lines, -37 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/generated.gni View 1 chunk +2 lines, -57 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/generated.gypi View 1 chunk +2 lines, -56 lines 0 comments Download
M third_party/WebKit/Source/bindings/modules/v8/V8BindingForModulesTest.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/modules/v8/generated.gni View 1 chunk +2 lines, -39 lines 0 comments Download
M third_party/WebKit/Source/bindings/modules/v8/generated.gypi View 1 chunk +2 lines, -38 lines 0 comments Download
M third_party/WebKit/Source/bindings/scripts/code_generator_v8.py View 6 chunks +55 lines, -66 lines 0 comments Download
M third_party/WebKit/Source/bindings/scripts/compute_interfaces_info_individual.py View 2 chunks +3 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/bindings/scripts/compute_interfaces_info_overall.py View 2 chunks +3 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/bindings/scripts/utilities.py View 3 chunks +7 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/bindings/scripts/v8_union.py View 5 chunks +37 lines, -14 lines 0 comments Download
M third_party/WebKit/Source/bindings/templates/templates.gni View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/bindings/templates/templates.gypi View 1 chunk +2 lines, -2 lines 0 comments Download
A third_party/WebKit/Source/bindings/templates/union.h View 1 chunk +79 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/bindings/templates/union.cpp View 1 chunk +203 lines, -0 lines 0 comments Download
D third_party/WebKit/Source/bindings/templates/union_container.h View 1 chunk +0 lines, -75 lines 0 comments Download
D third_party/WebKit/Source/bindings/templates/union_container.cpp View 1 chunk +0 lines, -201 lines 0 comments Download
D third_party/WebKit/Source/bindings/tests/results/core/ArrayBufferOrArrayBufferViewOrDictionary.h View 1 chunk +0 lines, -89 lines 0 comments Download
D third_party/WebKit/Source/bindings/tests/results/core/ArrayBufferOrArrayBufferViewOrDictionary.cpp View 1 chunk +0 lines, -147 lines 0 comments Download
D third_party/WebKit/Source/bindings/tests/results/core/BooleanOrStringOrUnrestrictedDouble.h View 1 chunk +0 lines, -87 lines 0 comments Download
D third_party/WebKit/Source/bindings/tests/results/core/BooleanOrStringOrUnrestrictedDouble.cpp View 1 chunk +0 lines, -141 lines 0 comments Download
D third_party/WebKit/Source/bindings/tests/results/core/DoubleOrString.h View 1 chunk +0 lines, -80 lines 0 comments Download
D third_party/WebKit/Source/bindings/tests/results/core/DoubleOrString.cpp View 1 chunk +0 lines, -114 lines 0 comments Download
D third_party/WebKit/Source/bindings/tests/results/core/LongOrTestDictionary.h View 1 chunk +0 lines, -81 lines 0 comments Download
D third_party/WebKit/Source/bindings/tests/results/core/LongOrTestDictionary.cpp View 1 chunk +0 lines, -126 lines 0 comments Download
D third_party/WebKit/Source/bindings/tests/results/core/NodeOrNodeList.h View 1 chunk +0 lines, -82 lines 0 comments Download
D third_party/WebKit/Source/bindings/tests/results/core/NodeOrNodeList.cpp View 1 chunk +0 lines, -119 lines 0 comments Download
D third_party/WebKit/Source/bindings/tests/results/core/StringOrArrayBufferOrArrayBufferView.h View 1 chunk +0 lines, -89 lines 0 comments Download
D third_party/WebKit/Source/bindings/tests/results/core/StringOrArrayBufferOrArrayBufferView.cpp View 1 chunk +0 lines, -145 lines 0 comments Download
D third_party/WebKit/Source/bindings/tests/results/core/StringOrDouble.h View 1 chunk +0 lines, -80 lines 0 comments Download
D third_party/WebKit/Source/bindings/tests/results/core/StringOrDouble.cpp View 1 chunk +0 lines, -114 lines 0 comments Download
D third_party/WebKit/Source/bindings/tests/results/core/StringOrStringSequence.h View 1 chunk +0 lines, -80 lines 0 comments Download
D third_party/WebKit/Source/bindings/tests/results/core/StringOrStringSequence.cpp View 1 chunk +0 lines, -114 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/TestDictionary.h View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/TestDictionary.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/TestDictionaryDerivedImplementedAs.h View 1 chunk +1 line, -1 line 0 comments Download
D third_party/WebKit/Source/bindings/tests/results/core/TestEnumOrDouble.h View 1 chunk +0 lines, -80 lines 0 comments Download
D third_party/WebKit/Source/bindings/tests/results/core/TestEnumOrDouble.cpp View 1 chunk +0 lines, -133 lines 0 comments Download
D third_party/WebKit/Source/bindings/tests/results/core/TestInterface2OrUint8Array.h View 1 chunk +0 lines, -82 lines 0 comments Download
D third_party/WebKit/Source/bindings/tests/results/core/TestInterface2OrUint8Array.cpp View 1 chunk +0 lines, -117 lines 0 comments Download
D third_party/WebKit/Source/bindings/tests/results/core/TestInterfaceGarbageCollectedOrString.h View 1 chunk +0 lines, -81 lines 0 comments Download
D third_party/WebKit/Source/bindings/tests/results/core/TestInterfaceGarbageCollectedOrString.cpp View 1 chunk +0 lines, -114 lines 0 comments Download
D third_party/WebKit/Source/bindings/tests/results/core/TestInterfaceOrLong.h View 1 chunk +0 lines, -81 lines 0 comments Download
D third_party/WebKit/Source/bindings/tests/results/core/TestInterfaceOrLong.cpp View 1 chunk +0 lines, -126 lines 0 comments Download
D third_party/WebKit/Source/bindings/tests/results/core/TestInterfaceOrTestInterfaceEmpty.h View 1 chunk +0 lines, -82 lines 0 comments Download
D third_party/WebKit/Source/bindings/tests/results/core/TestInterfaceOrTestInterfaceEmpty.cpp View 1 chunk +0 lines, -119 lines 0 comments Download
A third_party/WebKit/Source/bindings/tests/results/core/UnionTypesCore.h View 1 chunk +813 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/bindings/tests/results/core/UnionTypesCore.cpp View 1 chunk +1562 lines, -0 lines 0 comments Download
D third_party/WebKit/Source/bindings/tests/results/core/UnrestrictedDoubleOrString.h View 1 chunk +0 lines, -80 lines 0 comments Download
D third_party/WebKit/Source/bindings/tests/results/core/UnrestrictedDoubleOrString.cpp View 1 chunk +0 lines, -114 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestDictionary.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestDictionaryDerived.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestInterface.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestInterface.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceConstructor.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceConstructor.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestObject.h View 1 chunk +0 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestObject.cpp View 2 chunks +1 line, -11 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestSpecialOperations.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestSpecialOperations.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestTypedefs.h View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestTypedefs.cpp View 1 chunk +1 line, -2 lines 0 comments Download
D third_party/WebKit/Source/bindings/tests/results/modules/BooleanOrString.h View 1 chunk +0 lines, -80 lines 0 comments Download
D third_party/WebKit/Source/bindings/tests/results/modules/BooleanOrString.cpp View 1 chunk +0 lines, -111 lines 0 comments Download
A third_party/WebKit/Source/bindings/tests/results/modules/UnionTypesModules.h View 1 chunk +81 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/bindings/tests/results/modules/UnionTypesModules.cpp View 1 chunk +110 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/modules/V8TestInterface5.h View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/modules/V8TestInterface5.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/animation/AnimationEffectTiming.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/animation/EffectInput.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/animation/EffectInputTest.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/animation/ElementAnimation.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/animation/KeyframeEffectTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/FontFace.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/cssom/StylePropertyMap.h View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/dom/DOMArrayPiece.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/Document.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/Node.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/URLSearchParams.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/events/EventTarget.h View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/fileapi/Blob.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/fileapi/File.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/fileapi/FileReader.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/ImageBitmapTest.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/FormData.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/HTMLAllCollection.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/HTMLCanvasElement.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLFormControlsCollection.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/HTMLFormElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/HTMLOptionsCollection.cpp View 1 chunk +1 line, -3 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLSelectElement.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/track/TrackEvent.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/track/vtt/VTTCue.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/imagebitmap/ImageBitmapFactories.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/testing/DictionaryTest.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/testing/UnionTypesTest.h View 1 chunk +1 line, -5 lines 0 comments Download
M third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/beacon/NavigatorBeacon.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTServer.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTService.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/bluetooth/BluetoothUUID.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/cachestorage/Cache.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/canvas2d/BaseRenderingContext2D.h View 1 chunk +2 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2D.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2D.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/credentialmanager/PasswordCredential.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/crypto/NormalizeAlgorithm.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/crypto/NormalizeAlgorithm.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/crypto/SubtleCrypto.h View 1 chunk +1 line, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/encoding/TextDecoder.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/encryptedmedia/MediaKeyStatusMap.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/encryptedmedia/MediaKeyStatusMap.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/fetch/Request.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/fetch/Response.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/imagebitmap/ImageBitmapRenderingContext.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/indexeddb/IDBDatabase.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/indexeddb/IDBKeyPath.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/indexeddb/IDBObjectStore.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/indexeddb/IDBTransaction.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/mediastream/RTCPeerConnection.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/nfc/NFC.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/notifications/NotificationDataTest.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/offscreencanvas2d/OffscreenCanvasRenderingContext2D.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/push_messaging/PushManager.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/push_messaging/PushManagerTest.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/push_messaging/PushMessageData.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/serviceworkers/InstallEvent.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerGlobalScope.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/vibration/NavigatorVibration.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webgl/WebGL2RenderingContext.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/webgl/WebGLRenderingContext.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/websockets/DOMWebSocket.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webusb/USBDevice.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
bashi
Created Revert of Generate separate files for union type containers
4 years, 7 months ago (2016-05-12 23:16:20 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1974143002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1974143002/1
4 years, 7 months ago (2016-05-12 23:16:45 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-12 23:18:58 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/86c39ef8dc835af7cdef08020fa9d80eb1d9078d Cr-Commit-Position: refs/heads/master@{#393389}
4 years, 7 months ago (2016-05-12 23:20:22 UTC) #5
haraken
4 years, 7 months ago (2016-05-13 00:06:17 UTC) #6
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698