third_party/WebKit/Source/bindings/scripts/compute_interfaces_info_individual.py - Issue 1974143002: Revert of Generate separate files for union type containers

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/scripts/compute_interfaces_info_individual.py

Issue 1974143002: Revert of Generate separate files for union type containers (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/scripts/code_generator_v8.py ('k') | third_party/WebKit/Source/bindings/scripts/compute_interfaces_info_overall.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/scripts/compute_interfaces_info_individual.py

diff --git a/third_party/WebKit/Source/bindings/scripts/compute_interfaces_info_individual.py b/third_party/WebKit/Source/bindings/scripts/compute_interfaces_info_individual.py

index 14e9767150a9b1fb25e2652c71145f279701da4f..26af9fe7d95e27b252ed5da3649fe1f0ab22a212 100755

--- a/third_party/WebKit/Source/bindings/scripts/compute_interfaces_info_individual.py

+++ b/third_party/WebKit/Source/bindings/scripts/compute_interfaces_info_individual.py

@@ -266,11 +266,9 @@

partial_include_paths = []

if this_include_path:

partial_include_paths.append(this_include_path)

- for union_type in this_union_types:

- if union_type.is_nullable:

- union_type = union_type.inner_type

+ if this_union_types:

partial_include_paths.append(

- 'bindings/%s/v8/%s.h' % (component, union_type.name))

+ 'bindings/%s/v8/UnionTypes%s.h' % (component, component.capitalize()))

self.add_paths_to_partials_dict(definition.name, full_path, partial_include_paths)

# Collects C++ header paths which should be included from generated

# .cpp files. The resulting structure is as follows.

@@ -297,7 +295,7 @@

interface_info.update({

'extended_attributes': extended_attributes,

'full_path': full_path,

- 'union_types': this_union_types,

+ 'has_union_types': bool(this_union_types),

'implemented_as': implemented_as,

'implemented_by_interfaces': left_interfaces,

'implements_interfaces': right_interfaces,