src/runtime/runtime-debug.cc - Issue 1973213003: [liveedit] fix stepping after replacing bytecode.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/runtime/runtime-debug.cc

Issue 1973213003: [liveedit] fix stepping after replacing bytecode. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@liveeditbreaks

Patch Set: add another testcase Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/runtime/runtime-debug.cc

diff --git a/src/runtime/runtime-debug.cc b/src/runtime/runtime-debug.cc

index 94c2992fc2965ac022244d902803ef59390d1ce9..ae11d5fc5d397ac17f51aa2254b543ca1415dff7 100644

--- a/src/runtime/runtime-debug.cc

+++ b/src/runtime/runtime-debug.cc

@@ -42,6 +42,9 @@ RUNTIME_FUNCTION(Runtime_DebugBreakOnBytecode) {

JavaScriptFrameIterator it(isolate);

isolate->debug()->Break(it.frame());

+ // If live-edit has dropped frames, we are not going back to dispatch.

+ if (LiveEdit::SetAfterBreakTarget(isolate->debug())) return Smi::FromInt(0);

// Return the handler from the original bytecode array.

DCHECK(it.frame()->is_interpreted());

InterpretedFrame* interpreted_frame =

« no previous file with comments | « src/debug/liveedit.cc ('k') | test/mjsunit/debug-liveedit-exceptions.js » ('j') | no next file with comments »