Views: Change View::RequestFocus to respect keyboard accessibility.

Views: Change View::RequestFocus to respect keyboard accessibility.

This CL fixes some regressions introduced in http://crrev.com/1894383002/. These
regression are caused due to the change in View::RequestFocus() from
IsFocusable() to IsAccessibilityFocusable().

On a mouse click on a CustomButton, CustomButton::MousePressed() requests focus
on the button, if it has request_focus_on_press_ set to true. It turns out that
most button subclasses, do not explicitly set request_focus_on_press_ to false,
which has a default value of true. These custom buttons which are accessibility
focusable, can now gain focus on a mouse press, hence the bug.

This CL changes View::RequestFocus to use IsFocusable when keyboard
accessibility is off (i.e on Non-Mac platforms), hence fixing bugs 609701,
610186, 610235, 610740, 610802, 610664. This is how View::RequestFocus behaved
before crrev.com/1894383002 on Non-Mac platforms. Also, on Mac, since
View::RequestFocus now respects keyboard accessibility, bug 611280 is also
fixed.

BUG=609701, 610186, 610235, 610740, 610802, 610664, 564912, 611280
Committed: https://crrev.com/8c6b2ee186d786623f0e4cb6d05c08c934c0ff9b
Cr-Commit-Position: refs/heads/master@{#393781}

[karandeepb, 2016-05-13 06:30:00]

Description was changed from

==========
Full keyboard access regression.
==========

to

==========
Views: Change View::RequestFocus to respect keyboard accessibility.

This CL fixes regression crbug.com/609701 introduced in 
https://codereview.chromium.org/1894383002/. This regression is caused due to 
the change in View::RequestFocus() from IsFocusable() to 
IsAccessibilityFocusable(). 

On a mouse click on a CustomButton, CustomButton::MousePressed() requests focus 
on the button, if it has request_focus_on_press_ set to true. It turns out that 
most button subclasses, do not explicitly set request_focus_on_press_ to false,
which has a default value of true. These custom buttons which are accessibility
focusable, can now gain focus on a mouse press, hence the bug.

This CL changes View::RequestFocus to use IsFocusable when keyboard 
accessibility is off (i.e on Non-Mac platforms), hence fixing bugs 609701, 
610186, 610235, 610740, 610802, 610664. Also, on Mac, since View::RequestFocus
now respects keyboard accessibility, bug 611280 is also fixed.

BUG=609701, 610186, 610235, 610740, 610802, 610664, 564912, 611280
==========

[karandeepb, 2016-05-13 06:41:09]

Description was changed from

==========
Views: Change View::RequestFocus to respect keyboard accessibility.

This CL fixes regression crbug.com/609701 introduced in 
https://codereview.chromium.org/1894383002/. This regression is caused due to 
the change in View::RequestFocus() from IsFocusable() to 
IsAccessibilityFocusable(). 

On a mouse click on a CustomButton, CustomButton::MousePressed() requests focus 
on the button, if it has request_focus_on_press_ set to true. It turns out that 
most button subclasses, do not explicitly set request_focus_on_press_ to false,
which has a default value of true. These custom buttons which are accessibility
focusable, can now gain focus on a mouse press, hence the bug.

This CL changes View::RequestFocus to use IsFocusable when keyboard 
accessibility is off (i.e on Non-Mac platforms), hence fixing bugs 609701, 
610186, 610235, 610740, 610802, 610664. Also, on Mac, since View::RequestFocus
now respects keyboard accessibility, bug 611280 is also fixed.

BUG=609701, 610186, 610235, 610740, 610802, 610664, 564912, 611280
==========

to

==========
Views: Change View::RequestFocus to respect keyboard accessibility.

This CL fixes some regressions introduced in http://crrev.com/1894383002/. These
regression are caused due to the change in View::RequestFocus() from 
IsFocusable() to IsAccessibilityFocusable().

On a mouse click on a CustomButton, CustomButton::MousePressed() requests focus 
on the button, if it has request_focus_on_press_ set to true. It turns out that 
most button subclasses, do not explicitly set request_focus_on_press_ to false,
which has a default value of true. These custom buttons which are accessibility
focusable, can now gain focus on a mouse press, hence the bug.

This CL changes View::RequestFocus to use IsFocusable when keyboard 
accessibility is off (i.e on Non-Mac platforms), hence fixing bugs 609701, 
610186, 610235, 610740, 610802, 610664. This is how View::RequestFocus behaved 
before crrev.com/1894383002 on Non-Mac platforms. Also, on Mac, since 
View::RequestFocus now respects keyboard accessibility, bug 611280 is also 
fixed.

BUG=609701, 610186, 610235, 610740, 610802, 610664, 564912, 611280
==========

[karandeepb, 2016-05-13 09:05:31]

karandeepb@chromium.org changed reviewers:
+ sky@chromium.org

[karandeepb, 2016-05-13 09:05:32]

PTAL sky@. I also had another CL https://codereview.chromium.org/1963563002/ 
which fixed these bugs, but this is a better approach as it reverses the changes
introduced in https://codereview.chromium.org/1894383002/ for Non-Mac platforms.

Also, I think I should still go ahead with 
https://codereview.chromium.org/1963563002/, since most button subclasses
have the property request_focus_on_press_ wrongly set. Thoughts?

https://codereview.chromium.org/1973073003/diff/60001/ui/views/focus/focus_ma...
File ui/views/focus/focus_manager.cc (right):

https://codereview.chromium.org/1973073003/diff/60001/ui/views/focus/focus_ma...
ui/views/focus/focus_manager.cc:390: if (view) {
This is the same as the code before https://codereview.chromium.org/1894383002/
except the additions on line 407-411.

[sky, 2016-05-13 15:52:58]

LGTM

[sky, 2016-05-13 15:54:29]

I'm ok with changing the default of request_focus_on_press.

[karandeepb, 2016-05-15 23:59:12]

The CQ bit was checked by karandeepb@chromium.org

[commit-bot: I haz the power, 2016-05-15 23:59:15]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1973073003/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1973073003/60001

[karandeepb, 2016-05-15 23:59:16]

The CQ bit was unchecked by karandeepb@chromium.org

[karandeepb, 2016-05-16 00:05:46]

The CQ bit was checked by karandeepb@chromium.org

[commit-bot: I haz the power, 2016-05-16 00:05:54]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1973073003/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1973073003/60001

[commit-bot: I haz the power, 2016-05-16 01:14:54]

Description was changed from

==========
Views: Change View::RequestFocus to respect keyboard accessibility.

This CL fixes some regressions introduced in http://crrev.com/1894383002/. These
regression are caused due to the change in View::RequestFocus() from 
IsFocusable() to IsAccessibilityFocusable().

On a mouse click on a CustomButton, CustomButton::MousePressed() requests focus 
on the button, if it has request_focus_on_press_ set to true. It turns out that 
most button subclasses, do not explicitly set request_focus_on_press_ to false,
which has a default value of true. These custom buttons which are accessibility
focusable, can now gain focus on a mouse press, hence the bug.

This CL changes View::RequestFocus to use IsFocusable when keyboard 
accessibility is off (i.e on Non-Mac platforms), hence fixing bugs 609701, 
610186, 610235, 610740, 610802, 610664. This is how View::RequestFocus behaved 
before crrev.com/1894383002 on Non-Mac platforms. Also, on Mac, since 
View::RequestFocus now respects keyboard accessibility, bug 611280 is also 
fixed.

BUG=609701, 610186, 610235, 610740, 610802, 610664, 564912, 611280
==========

to

==========
Views: Change View::RequestFocus to respect keyboard accessibility.

This CL fixes some regressions introduced in http://crrev.com/1894383002/. These
regression are caused due to the change in View::RequestFocus() from 
IsFocusable() to IsAccessibilityFocusable().

On a mouse click on a CustomButton, CustomButton::MousePressed() requests focus 
on the button, if it has request_focus_on_press_ set to true. It turns out that 
most button subclasses, do not explicitly set request_focus_on_press_ to false,
which has a default value of true. These custom buttons which are accessibility
focusable, can now gain focus on a mouse press, hence the bug.

This CL changes View::RequestFocus to use IsFocusable when keyboard 
accessibility is off (i.e on Non-Mac platforms), hence fixing bugs 609701, 
610186, 610235, 610740, 610802, 610664. This is how View::RequestFocus behaved 
before crrev.com/1894383002 on Non-Mac platforms. Also, on Mac, since 
View::RequestFocus now respects keyboard accessibility, bug 611280 is also 
fixed.

BUG=609701, 610186, 610235, 610740, 610802, 610664, 564912, 611280
==========

[commit-bot: I haz the power, 2016-05-16 01:14:56]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-05-16 01:16:33]

Description was changed from

==========
Views: Change View::RequestFocus to respect keyboard accessibility.

This CL fixes some regressions introduced in http://crrev.com/1894383002/. These
regression are caused due to the change in View::RequestFocus() from 
IsFocusable() to IsAccessibilityFocusable().

On a mouse click on a CustomButton, CustomButton::MousePressed() requests focus 
on the button, if it has request_focus_on_press_ set to true. It turns out that 
most button subclasses, do not explicitly set request_focus_on_press_ to false,
which has a default value of true. These custom buttons which are accessibility
focusable, can now gain focus on a mouse press, hence the bug.

This CL changes View::RequestFocus to use IsFocusable when keyboard 
accessibility is off (i.e on Non-Mac platforms), hence fixing bugs 609701, 
610186, 610235, 610740, 610802, 610664. This is how View::RequestFocus behaved 
before crrev.com/1894383002 on Non-Mac platforms. Also, on Mac, since 
View::RequestFocus now respects keyboard accessibility, bug 611280 is also 
fixed.

BUG=609701, 610186, 610235, 610740, 610802, 610664, 564912, 611280
==========

to

==========
Views: Change View::RequestFocus to respect keyboard accessibility.

This CL fixes some regressions introduced in http://crrev.com/1894383002/. These
regression are caused due to the change in View::RequestFocus() from
IsFocusable() to IsAccessibilityFocusable().

On a mouse click on a CustomButton, CustomButton::MousePressed() requests focus
on the button, if it has request_focus_on_press_ set to true. It turns out that
most button subclasses, do not explicitly set request_focus_on_press_ to false,
which has a default value of true. These custom buttons which are accessibility
focusable, can now gain focus on a mouse press, hence the bug.

This CL changes View::RequestFocus to use IsFocusable when keyboard
accessibility is off (i.e on Non-Mac platforms), hence fixing bugs 609701,
610186, 610235, 610740, 610802, 610664. This is how View::RequestFocus behaved
before crrev.com/1894383002 on Non-Mac platforms. Also, on Mac, since
View::RequestFocus now respects keyboard accessibility, bug 611280 is also
fixed.

BUG=609701, 610186, 610235, 610740, 610802, 610664, 564912, 611280

Committed: https://crrev.com/8c6b2ee186d786623f0e4cb6d05c08c934c0ff9b
Cr-Commit-Position: refs/heads/master@{#393781}
==========

[commit-bot: I haz the power, 2016-05-16 01:16:36]

Patchset 4 (id:??) landed as
https://crrev.com/8c6b2ee186d786623f0e4cb6d05c08c934c0ff9b
Cr-Commit-Position: refs/heads/master@{#393781}