Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1136)

Unified Diff: ui/views/view.cc

Issue 1973073003: Views: Change View::RequestFocus to respect keyboard accessibility. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add RequestFocus test Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/views/view.cc
diff --git a/ui/views/view.cc b/ui/views/view.cc
index 0e733ad6a898f01863c3eccbda30c5de2bc15237..be3bbf5b7ed29370ae2f344bf04420ee029dbe93 100644
--- a/ui/views/view.cc
+++ b/ui/views/view.cc
@@ -1226,8 +1226,13 @@ const FocusManager* View::GetFocusManager() const {
void View::RequestFocus() {
FocusManager* focus_manager = GetFocusManager();
- if (focus_manager && IsAccessibilityFocusable())
- focus_manager->SetFocusedView(this);
+ if (focus_manager) {
+ bool focusable = focus_manager->keyboard_accessible()
+ ? IsAccessibilityFocusable()
+ : IsFocusable();
+ if (focusable)
+ focus_manager->SetFocusedView(this);
+ }
}
bool View::SkipDefaultKeyEventProcessing(const ui::KeyEvent& event) {
« ui/views/focus/focus_manager.cc ('K') | « ui/views/focus/focus_manager_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698