[MD settings] update i18n replacements in a11y, privacy, reset, and search

[MD settings] update i18n replacements in a11y, privacy, reset, and search

This CL has mechanical changes to convert from the i18n-content and
i18n-values to $i18n{}.

BUG=611188
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/00a261827077cdfe04f3acb7f341c69d23d3ceab
Cr-Commit-Position: refs/heads/master@{#393085}

[dschuyler, 2016-05-11 00:47:12]

Description was changed from

==========
[MD settings] update i18n replacements in a11y, privacy, reset, and search

This CL has mechanical changes to convert from the i18n-content and
i18n-values to $i18n{}.

BUG=546840, 608535, 517564
==========

to

==========
[MD settings] update i18n replacements in a11y, privacy, reset, and search

This CL has mechanical changes to convert from the i18n-content and
i18n-values to $i18n{}.

BUG=546840, 608535, 517564
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

[dschuyler, 2016-05-11 00:48:12]

dschuyler@chromium.org changed reviewers:
+ dpapad@chromium.org

[dpapad, 2016-05-11 01:02:26]

LGTM.

Regarding the bugs linked to this CL, I think it would be better to have a
single  bug that tracks the i18n-content/values to $i18n{} transition instead
for the entire MD Settings, since the transition is very indirectly related to
"implementing" those sections.

It would also provide a good source of data for the future (for example it would
depict
 - how many CLs did it take,
 - how many developers contributed,
 - how long did the transition take,
 - which sections are left to be converted

https://codereview.chromium.org/1971443003/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/a11y_page/a11y_page.html (right):

https://codereview.chromium.org/1971443003/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/a11y_page/a11y_page.html:14: <a
i18n-values="href:a11yLearnMoreUrl"
Should this also be converted?
href="$i18n{a11yLearnMoreUrl}"

https://codereview.chromium.org/1971443003/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/reset_page/powerwash_dialog.html (right):

https://codereview.chromium.org/1971443003/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/reset_page/powerwash_dialog.html:17: <a
i18n-values="href:powerwashLearnMoreUrl"
Same here.

https://codereview.chromium.org/1971443003/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/reset_page/reset_profile_banner.html
(right):

https://codereview.chromium.org/1971443003/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/reset_page/reset_profile_banner.html:20:
i18n-values="href:resetProfileBannerLearnMoreUrl"
And here.

https://codereview.chromium.org/1971443003/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/reset_page/reset_profile_dialog.html
(right):

https://codereview.chromium.org/1971443003/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/reset_page/reset_profile_dialog.html:24: <a
i18n-values="href:resetPageLearnMoreUrl"
And here.

[dschuyler, 2016-05-11 01:05:45]

Patchset #2 (id:20001) has been deleted

[dschuyler, 2016-05-11 20:50:18]

Description was changed from

==========
[MD settings] update i18n replacements in a11y, privacy, reset, and search

This CL has mechanical changes to convert from the i18n-content and
i18n-values to $i18n{}.

BUG=546840, 608535, 517564
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

to

==========
[MD settings] update i18n replacements in a11y, privacy, reset, and search

This CL has mechanical changes to convert from the i18n-content and
i18n-values to $i18n{}.

BUG=5611188
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

[dschuyler, 2016-05-11 21:24:22]

https://codereview.chromium.org/1971443003/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/a11y_page/a11y_page.html (right):

https://codereview.chromium.org/1971443003/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/a11y_page/a11y_page.html:14: <a
i18n-values="href:a11yLearnMoreUrl"
On 2016/05/11 01:02:26, dpapad wrote:
> Should this also be converted?
> href="$i18n{a11yLearnMoreUrl}"

Done.

https://codereview.chromium.org/1971443003/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/reset_page/powerwash_dialog.html (right):

https://codereview.chromium.org/1971443003/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/reset_page/powerwash_dialog.html:17: <a
i18n-values="href:powerwashLearnMoreUrl"
On 2016/05/11 01:02:26, dpapad wrote:
> Same here.

Done.

https://codereview.chromium.org/1971443003/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/reset_page/reset_profile_banner.html
(right):

https://codereview.chromium.org/1971443003/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/reset_page/reset_profile_banner.html:20:
i18n-values="href:resetProfileBannerLearnMoreUrl"
On 2016/05/11 01:02:26, dpapad wrote:
> And here.

Done.

https://codereview.chromium.org/1971443003/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/reset_page/reset_profile_dialog.html
(right):

https://codereview.chromium.org/1971443003/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/reset_page/reset_profile_dialog.html:24: <a
i18n-values="href:resetPageLearnMoreUrl"
On 2016/05/11 01:02:26, dpapad wrote:
> And here.

Done.

[dpapad, 2016-05-11 21:27:50]

On 2016/05/11 at 21:24:22, dschuyler wrote:
>
https://codereview.chromium.org/1971443003/diff/1/chrome/browser/resources/se...
> File chrome/browser/resources/settings/a11y_page/a11y_page.html (right):
> 
>
https://codereview.chromium.org/1971443003/diff/1/chrome/browser/resources/se...
> chrome/browser/resources/settings/a11y_page/a11y_page.html:14: <a
i18n-values="href:a11yLearnMoreUrl"
> On 2016/05/11 01:02:26, dpapad wrote:
> > Should this also be converted?
> > href="$i18n{a11yLearnMoreUrl}"
> 
> Done.
> 
>
https://codereview.chromium.org/1971443003/diff/1/chrome/browser/resources/se...
> File chrome/browser/resources/settings/reset_page/powerwash_dialog.html
(right):
> 
>
https://codereview.chromium.org/1971443003/diff/1/chrome/browser/resources/se...
> chrome/browser/resources/settings/reset_page/powerwash_dialog.html:17: <a
i18n-values="href:powerwashLearnMoreUrl"
> On 2016/05/11 01:02:26, dpapad wrote:
> > Same here.
> 
> Done.
> 
>
https://codereview.chromium.org/1971443003/diff/1/chrome/browser/resources/se...
> File chrome/browser/resources/settings/reset_page/reset_profile_banner.html
(right):
> 
>
https://codereview.chromium.org/1971443003/diff/1/chrome/browser/resources/se...
> chrome/browser/resources/settings/reset_page/reset_profile_banner.html:20:
i18n-values="href:resetProfileBannerLearnMoreUrl"
> On 2016/05/11 01:02:26, dpapad wrote:
> > And here.
> 
> Done.
> 
>
https://codereview.chromium.org/1971443003/diff/1/chrome/browser/resources/se...
> File chrome/browser/resources/settings/reset_page/reset_profile_dialog.html
(right):
> 
>
https://codereview.chromium.org/1971443003/diff/1/chrome/browser/resources/se...
> chrome/browser/resources/settings/reset_page/reset_profile_dialog.html:24: <a
i18n-values="href:resetPageLearnMoreUrl"
> On 2016/05/11 01:02:26, dpapad wrote:
> > And here.
> 
> Done.

Bug number has a typo, should be 611188.

[dschuyler, 2016-05-11 21:29:37]

Description was changed from

==========
[MD settings] update i18n replacements in a11y, privacy, reset, and search

This CL has mechanical changes to convert from the i18n-content and
i18n-values to $i18n{}.

BUG=5611188
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

to

==========
[MD settings] update i18n replacements in a11y, privacy, reset, and search

This CL has mechanical changes to convert from the i18n-content and
i18n-values to $i18n{}.

BUG=611188
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

[dschuyler, 2016-05-11 22:06:24]

The CQ bit was checked by dschuyler@chromium.org

[dschuyler, 2016-05-11 22:06:25]

The patchset sent to the CQ was uploaded after l-g-t-m from dpapad@chromium.org
Link to the patchset: https://codereview.chromium.org/1971443003/#ps40001
(title: "i18n-values")

[commit-bot: I haz the power, 2016-05-11 22:06:58]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1971443003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1971443003/40001

[Dan Beam, 2016-05-11 22:09:44]

https://codereview.chromium.org/1971443003/diff/40001/chrome/browser/resource...
File chrome/browser/resources/settings/reset_page/powerwash_dialog.html (right):

https://codereview.chromium.org/1971443003/diff/40001/chrome/browser/resource...
chrome/browser/resources/settings/reset_page/powerwash_dialog.html:16:
$i18n{powerwashDialogExplanation} 
why is this   here?

[commit-bot: I haz the power, 2016-05-11 22:14:47]

Description was changed from

==========
[MD settings] update i18n replacements in a11y, privacy, reset, and search

This CL has mechanical changes to convert from the i18n-content and
i18n-values to $i18n{}.

BUG=611188
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

to

==========
[MD settings] update i18n replacements in a11y, privacy, reset, and search

This CL has mechanical changes to convert from the i18n-content and
i18n-values to $i18n{}.

BUG=611188
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

[commit-bot: I haz the power, 2016-05-11 22:14:48]

Committed patchset #2 (id:40001)

[commit-bot: I haz the power, 2016-05-11 22:16:05]

Description was changed from

==========
[MD settings] update i18n replacements in a11y, privacy, reset, and search

This CL has mechanical changes to convert from the i18n-content and
i18n-values to $i18n{}.

BUG=611188
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

to

==========
[MD settings] update i18n replacements in a11y, privacy, reset, and search

This CL has mechanical changes to convert from the i18n-content and
i18n-values to $i18n{}.

BUG=611188
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/00a261827077cdfe04f3acb7f341c69d23d3ceab
Cr-Commit-Position: refs/heads/master@{#393085}
==========

[commit-bot: I haz the power, 2016-05-11 22:16:07]

Patchset 2 (id:??) landed as
https://crrev.com/00a261827077cdfe04f3acb7f341c69d23d3ceab
Cr-Commit-Position: refs/heads/master@{#393085}

[dschuyler, 2016-05-11 22:25:00]

https://codereview.chromium.org/1971443003/diff/40001/chrome/browser/resource...
File chrome/browser/resources/settings/reset_page/powerwash_dialog.html (right):

https://codereview.chromium.org/1971443003/diff/40001/chrome/browser/resource...
chrome/browser/resources/settings/reset_page/powerwash_dialog.html:16:
$i18n{powerwashDialogExplanation} 
On 2016/05/11 22:09:44, Dan Beam wrote:
> why is this   here?

Without the   the link is right-on-top of 
the end of the sentence. We could also wrap it
in a <span> or use some styling.

[Dan Beam, 2016-05-11 22:27:39]

dbeam@chromium.org changed reviewers:
+ dbeam@chromium.org

[Dan Beam, 2016-05-11 22:27:41]

https://codereview.chromium.org/1971443003/diff/40001/chrome/browser/resource...
File chrome/browser/resources/settings/reset_page/powerwash_dialog.html (right):

https://codereview.chromium.org/1971443003/diff/40001/chrome/browser/resource...
chrome/browser/resources/settings/reset_page/powerwash_dialog.html:16:
$i18n{powerwashDialogExplanation} 
On 2016/05/11 22:25:00, dschuyler wrote:
> On 2016/05/11 22:09:44, Dan Beam wrote:
> > why is this   here?
> 
> Without the   the link is right-on-top of 
> the end of the sentence. We could also wrap it
> in a <span> or use some styling.

with the &nbsp;, it may not wrap correctly, right?

[dschuyler, 2016-05-11 22:55:50]

https://codereview.chromium.org/1971443003/diff/40001/chrome/browser/resource...
File chrome/browser/resources/settings/reset_page/powerwash_dialog.html (right):

https://codereview.chromium.org/1971443003/diff/40001/chrome/browser/resource...
chrome/browser/resources/settings/reset_page/powerwash_dialog.html:16:
$i18n{powerwashDialogExplanation} 
On 2016/05/11 22:27:40, Dan Beam wrote:
> On 2016/05/11 22:25:00, dschuyler wrote:
> > On 2016/05/11 22:09:44, Dan Beam wrote:
> > > why is this   here?
> > 
> > Without the   the link is right-on-top of 
> > the end of the sentence. We could also wrap it
> > in a <span> or use some styling.
> 
> with the &nbsp;, it may not wrap correctly, right?

I'll change it to a <span>

(It's very hard to see the difference. The <span> will
wrap just a few pixels earlier).

[michaelpg, 2016-05-12 03:02:53]

michaelpg@chromium.org changed reviewers:
+ michaelpg@chromium.org

[michaelpg, 2016-05-12 03:02:54]

https://codereview.chromium.org/1971443003/diff/40001/chrome/browser/resource...
File chrome/browser/resources/settings/privacy_page/privacy_page.html (right):

https://codereview.chromium.org/1971443003/diff/40001/chrome/browser/resource...
chrome/browser/resources/settings/privacy_page/privacy_page.html:35:
$i18n{improveBrowsingExperience}
does this need to be $i18nRaw? https://screenshot.googleplex.com/f2nBSfPr4Rk.png