Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Unified Diff: chrome/browser/resources/settings/reset_page/powerwash_dialog.html

Issue 1971443003: [MD settings] update i18n replacements in a11y, privacy, reset, and search (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: i18n-values Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/reset_page/powerwash_dialog.html
diff --git a/chrome/browser/resources/settings/reset_page/powerwash_dialog.html b/chrome/browser/resources/settings/reset_page/powerwash_dialog.html
index a6942696e2c2ee5de8ad23dc6d4bda9ed182f937..7830870aadff899b897a757f769a01aefa1b119f 100644
--- a/chrome/browser/resources/settings/reset_page/powerwash_dialog.html
+++ b/chrome/browser/resources/settings/reset_page/powerwash_dialog.html
@@ -11,18 +11,17 @@
<template>
<style include="settings-shared"></style>
<settings-dialog id="dialog">
- <div class="title" i18n-content="powerwashDialogTitle"></div>
+ <div class="title">$i18n{powerwashDialogTitle}</div>
<div class="body">
- <span i18n-content="powerwashDialogExplanation"></span>
- <a i18n-values="href:powerwashLearnMoreUrl"
- i18n-content="learnMore" target="_blank"></a>
+ $i18n{powerwashDialogExplanation}&nbsp;
Dan Beam 2016/05/11 22:09:44 why is this &nbsp; here?
dschuyler 2016/05/11 22:25:00 Without the &nbsp; the link is right-on-top of th
Dan Beam 2016/05/11 22:27:40 with the &nbsp;, it may not wrap correctly, right?
dschuyler 2016/05/11 22:55:50 I'll change it to a <span> (It's very hard to see
+ <a href="$i18nRaw{powerwashLearnMoreUrl}"
+ target="_blank">$i18n{learnMore}</a>
</div>
<div class="button-container">
<paper-button class="cancel-button" on-tap="onCancelTap_"
- id="cancel" i18n-content="cancel"></paper-button>
+ id="cancel">$i18n{cancel}</paper-button>
<paper-button class="action-button" id="powerwash"
- on-tap="onRestartTap_" i18n-content="powerwashDialogButton">
- </paper-button>
+ on-tap="onRestartTap_">$i18n{powerwashDialogButton}</paper-button>
</div>
</settings-dialog>
</template>

Powered by Google App Engine
This is Rietveld 408576698