Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(348)

Unified Diff: chrome/browser/resources/settings/privacy_page/privacy_page.html

Issue 1971443003: [MD settings] update i18n replacements in a11y, privacy, reset, and search (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: i18n-values Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/privacy_page/privacy_page.html
diff --git a/chrome/browser/resources/settings/privacy_page/privacy_page.html b/chrome/browser/resources/settings/privacy_page/privacy_page.html
index 74cb40a8e6a7fee519cc9fbcc93e352b890d4029..b78bf576c0e5a0eb3db24dc397c44665f9da3a93 100644
--- a/chrome/browser/resources/settings/privacy_page/privacy_page.html
+++ b/chrome/browser/resources/settings/privacy_page/privacy_page.html
@@ -31,52 +31,52 @@
section="privacy">
<neon-animatable id="main">
<div class="settings-box block first">
- <p class="privacy-explanation"
- i18n-values=".innerHTML:improveBrowsingExperience">
+ <p class="privacy-explanation">
+ $i18n{improveBrowsingExperience}
michaelpg 2016/05/12 03:02:54 does this need to be $i18nRaw? https://screenshot.
</p>
<settings-checkbox
pref="{{prefs.alternate_error_pages.enabled}}"
- i18n-values="label:linkDoctorPref">
+ label="$i18n{linkDoctorPref}">
</settings-checkbox>
<settings-checkbox
pref="{{prefs.search.suggest_enabled}}"
- i18n-values="label:searchSuggestPref">
+ label="$i18n{searchSuggestPref}">
</settings-checkbox>
<settings-checkbox
pref="{{prefs.net.network_prediction_options}}"
- i18n-values="label:networkPredictionEnabled">
+ label="$i18n{networkPredictionEnabled}">
</settings-checkbox>
<settings-checkbox
pref="{{prefs.safebrowsing.extended_reporting_enabled}}"
- i18n-values="label:safeBrowsingEnableExtendedReporting">
+ label="$i18n{safeBrowsingEnableExtendedReporting}">
</settings-checkbox>
<settings-checkbox pref="{{prefs.safebrowsing.enabled}}"
- i18n-values="label:safeBrowsingEnableProtection">
+ label="$i18n{safeBrowsingEnableProtection}">
</settings-checkbox>
<if expr="_google_chrome">
<settings-checkbox
pref="{{prefs.spellcheck.use_spelling_service}}"
- i18n-values="label:spellingPref">
+ label="$i18n{spellingPref}">
</settings-checkbox>
<if expr="chromeos">
<settings-checkbox
pref="{{prefs.cros.metrics.reportingEnabled}}"
- i18n-values="label:enableLogging">
+ label="$i18n{enableLogging}">
</settings-checkbox>
</if>
<!-- TODO(jlklein): Add non-chromeos metrics box. -->
</if>
<settings-checkbox pref="{{prefs.enable_do_not_track}}"
- i18n-values="label:doNotTrack">
+ label="$i18n{doNotTrack}">
</settings-checkbox>
<if expr="chromeos">
<settings-checkbox
pref="{{prefs.cros.device.attestation_for_content_protection_enabled}}"
- i18n-values="label:enableContentProtectionAttestation">
+ label="$i18n{enableContentProtectionAttestation}">
</settings-checkbox>
<settings-checkbox
pref="{{prefs.settings.internet.wake_on_wifi_darkconnect}}"
- i18n-values="label:wakeOnWifi">
+ label="$i18n{wakeOnWifi}">
</settings-checkbox>
</if>
</div>
@@ -84,7 +84,7 @@
<div id="manageCertificates" class="settings-box two-line"
on-tap="onManageCertificatesTap_">
<div class="start">
- <div i18n-content="manageCertificates"></div>
+ <div>$i18n{manageCertificates}</div>
<div class="secondary">
<!-- TODO(dschuyler): replace this placeholder text -->
Contrary to popular belief, Lorem Ipsum is not simply random text.
@@ -94,7 +94,7 @@
</if>
<div class="settings-box two-line" on-tap="onSiteSettingsTap_">
<div class="start">
- <div i18n-content="siteSettings"></div>
+ <div>$i18n{siteSettings}</div>
<div class="secondary">
<!-- TODO(dschuyler): replace this placeholder text -->
Contrary to popular belief, Lorem Ipsum is not simply random text.
@@ -102,8 +102,8 @@
</div>
</div>
<div class="settings-box">
- <paper-button on-tap="onClearBrowsingDataTap_" class="primary-button"
- i18n-content="clearBrowsingData">
+ <paper-button on-tap="onClearBrowsingDataTap_" class="primary-button">
+ $i18n{clearBrowsingData}
</paper-button>
</div>
</neon-animatable>

Powered by Google App Engine
This is Rietveld 408576698