src/image/SkImage_Gpu.cpp - Issue 1971343002: Convert GrClip to an abstract base class

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/image/SkImage_Gpu.cpp

Issue 1971343002: Convert GrClip to an abstract base class (Closed) Base URL: https://skia.googlesource.com/skia.git@upload2_clipout

Patch Set: fix crash Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/image/SkImage_Gpu.cpp

diff --git a/src/image/SkImage_Gpu.cpp b/src/image/SkImage_Gpu.cpp

index 339dee7a5c7ef0d2bc839cff7b74ec871c1c5f50..2c2405839529f7aa27ffcef65536495542bd0490 100644

--- a/src/image/SkImage_Gpu.cpp

+++ b/src/image/SkImage_Gpu.cpp

@@ -269,7 +269,7 @@ sk_sp<SkImage> SkImage::MakeFromYUVTexturesCopy(GrContext* ctx , SkYUVColorSpace

const SkRect rect = SkRect::MakeWH(SkIntToScalar(width), SkIntToScalar(height));

- drawContext->drawRect(GrClip::WideOpen(), paint, SkMatrix::I(), rect);

+ drawContext->drawRect(GrNoClip(), paint, SkMatrix::I(), rect);

ctx->flushSurfaceWrites(drawContext->accessRenderTarget());

return sk_make_sp<SkImage_Gpu>(width, height, kNeedNewImageUniqueID,

kOpaque_SkAlphaType,

« no previous file with comments | « src/gpu/effects/GrConfigConversionEffect.cpp ('k') | tests/ClipBoundsTest.cpp » ('j') | no next file with comments »