src/gpu/effects/GrConfigConversionEffect.cpp - Issue 1971343002: Convert GrClip to an abstract base class

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/gpu/effects/GrConfigConversionEffect.cpp

Issue 1971343002: Convert GrClip to an abstract base class (Closed) Base URL: https://skia.googlesource.com/skia.git@upload2_clipout

Patch Set: fix crash Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/gpu/effects/GrConfigConversionEffect.cpp

diff --git a/src/gpu/effects/GrConfigConversionEffect.cpp b/src/gpu/effects/GrConfigConversionEffect.cpp

index 6b43606bb58584cb75bd9a8dc98d39de4d65b738..99a4884f0fed2a8c775a5813438b3cf6da697eba 100644

--- a/src/gpu/effects/GrConfigConversionEffect.cpp

+++ b/src/gpu/effects/GrConfigConversionEffect.cpp

@@ -232,7 +232,7 @@ void GrConfigConversionEffect::TestForPreservingPMConversions(GrContext* context

break;

}

- readDrawContext->fillRectToRect(GrClip::WideOpen(),

+ readDrawContext->fillRectToRect(GrNoClip(),

paint1,

SkMatrix::I(),

kDstRect,

@@ -249,7 +249,7 @@ void GrConfigConversionEffect::TestForPreservingPMConversions(GrContext* context

failed = true;

break;

}

- tempDrawContext->fillRectToRect(GrClip::WideOpen(),

+ tempDrawContext->fillRectToRect(GrNoClip(),

paint2,

SkMatrix::I(),

kDstRect,

@@ -264,7 +264,7 @@ void GrConfigConversionEffect::TestForPreservingPMConversions(GrContext* context

break;

}

- readDrawContext->fillRectToRect(GrClip::WideOpen(),

+ readDrawContext->fillRectToRect(GrNoClip(),

paint3,

SkMatrix::I(),

kDstRect,

« no previous file with comments | « src/gpu/SkGpuDevice.cpp ('k') | src/image/SkImage_Gpu.cpp » ('j') | no next file with comments »