tests/ClipBoundsTest.cpp - Issue 1971343002: Convert GrClip to an abstract base class

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tests/ClipBoundsTest.cpp

Issue 1971343002: Convert GrClip to an abstract base class (Closed) Base URL: https://skia.googlesource.com/skia.git@upload2_clipout

Patch Set: fix crash Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tests/ClipBoundsTest.cpp

diff --git a/tests/ClipBoundsTest.cpp b/tests/ClipBoundsTest.cpp

index 5660afdc27aa2cdb00b422509230113d3cbb1792..246cf6e60c514377bf021da5ee3ad69c41ca929d 100644

--- a/tests/ClipBoundsTest.cpp

+++ b/tests/ClipBoundsTest.cpp

@@ -40,8 +40,7 @@ DEF_GPUTEST_FOR_RENDERING_CONTEXTS(GrClipBounds, reporter, ctxInfo) {

REPORTER_ASSERT(reporter, isIntersectionOfRects);

// wrap the SkClipStack in a GrClip

- GrClip clipData;

- clipData.setClipStack(&stack);

+ GrClipStackClip clipData(&stack);

SkIRect devGrClipBound;

clipData.getConservativeBounds(kXSize, kYSize,

« no previous file with comments | « src/image/SkImage_Gpu.cpp ('k') | tests/TessellatingPathRendererTests.cpp » ('j') | no next file with comments »