Issue 1971283003: Temporary fix for "white patch" fullscreen regression on OSX

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1971283003: Temporary fix for "white patch" fullscreen regression on OSX (Closed)

Created:
4 years, 7 months ago by spqchan

Modified:
4 years, 7 months ago

Reviewers:

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@2704

Target Ref:
refs/pending/branch-heads/2704

Project:
chromium

Visibility:
Public.

Temporary fix for "white patch" fullscreen regression on OSX This is a partial revert of https://codereview.chromium.org/1790663003 which introduced the bug. While it doesn't fix the regression in popups, it will at least fix it for a normal browser window which is exposed to more users. BUG=604288 Review-Url: https://codereview.chromium.org/1967943002 Cr-Commit-Position: refs/heads/master@{#393027} (cherry picked from commit 07323681ff50e188b664ad404eaf3b04f9add5bc) Committed: https://chromium.googlesource.com/chromium/src/+/fa10a85611ad1b41ccc5f1f5e3ae96dfe8260e60

Created: 4 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+26 lines, -5 lines)			Patch
M	chrome/browser/ui/cocoa/tab_contents/tab_contents_controller.h	View	2 chunks	+4 lines, -1 line	0 comments	Download
M	chrome/browser/ui/cocoa/tab_contents/tab_contents_controller.mm	View	4 chunks	+16 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm	View	2 chunks	+6 lines, -2 lines	0 comments	Download

Total messages: 2 (1 generated)

spqchan

4 years, 7 months ago (2016-05-12 19:24:00 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
fa10a85611ad1b41ccc5f1f5e3ae96dfe8260e60.