Temporary fix for "white patch" fullscreen regression on OSX

chrome/browser/ui/cocoa/tab_contents/tab_contents_controller.mm

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "chrome/browser/ui/cocoa/tab_contents/tab_contents_controller.h"
 
 #include <stdint.h>
 
 #include <utility>
 
@@ skipping 59 matching lines @@
 };
 
 @interface TabContentsController (TabContentsContainerViewDelegate)
 - (BOOL)contentsInFullscreenCaptureMode;
 // Computes and returns the frame to use for the contents view within the
 // container view.
 - (NSRect)frameForContentsView;
 
 // Returns YES if the content view should be resized.
 - (BOOL)shouldResizeContentView;
+
+// Returns YES if the content view is inside a popup.
+- (BOOL)isPopup;
+
 @end
 
 // An NSView with special-case handling for when the contents view does not
 // expand to fill the entire tab contents area. See 'AutoEmbedFullscreen mode'
 // in header file comments.
 @interface TabContentsContainerView : NSView {
  @private
   TabContentsController* delegate_;  // weak
 }
 
@@ skipping 15 matching lines @@
 }
 
 // Called by the delegate during dealloc to invalidate the pointer held by this
 // view.
 - (void)delegateDestroyed {
   delegate_ = nil;
 }
 
 // Override auto-resizing logic to query the delegate for the exact frame to
 // use for the contents view.
+// TODO(spqchan): The popup check is a temporary solution to fix the regression
+// issue described in crbug.com/604288. This method doesn't really affect
+// fullscreen if the content is inside a normal browser window, but would
+// cause a flash fullscreen widget to blow up if it's inside a popup.
 - (void)resizeSubviewsWithOldSize:(NSSize)oldBoundsSize {
   NSView* const contentsView =
       [[self subviews] count] > 0 ? [[self subviews] objectAtIndex:0] : nil;
   if (!contentsView || [contentsView autoresizingMask] == NSViewNotSizable ||
-      !delegate_ || ![delegate_ shouldResizeContentView]) {
+      !delegate_ ||
+      (![delegate_ shouldResizeContentView] && [delegate_ isPopup])) {
     return;
   }
 
   ScopedCAActionDisabler disabler;
   [contentsView setFrame:[delegate_ frameForContentsView]];
 }
 
 // Update the background layer's color whenever the view needs to repaint.
 - (void)setNeedsDisplayInRect:(NSRect)rect {
   [super setNeedsDisplayInRect:rect];
@@ skipping 47 matching lines @@
 - (BOOL)canBecomeKeyView {
   return NO;  // Tab/Shift-Tab should focus the subview, not this view.
 }
 
 @end  // @implementation TabContentsContainerView
 
 @implementation TabContentsController
 @synthesize webContents = contents_;
 @synthesize blockFullscreenResize = blockFullscreenResize_;
 
-- (id)initWithContents:(WebContents*)contents {
+- (id)initWithContents:(WebContents*)contents isPopup:(BOOL)popup {
   if ((self = [super initWithNibName:nil bundle:nil])) {
     fullscreenObserver_.reset(new FullscreenObserver(self));
     [self changeWebContents:contents];
+    isPopup_ = popup;
   }
   return self;
 }
 
 - (void)dealloc {
   [static_cast<TabContentsContainerView*>([self view]) delegateDestroyed];
   // Make sure the contents view has been removed from the container view to
   // allow objects to be released.
   [[self view] removeFromSuperview];
   [super dealloc];
@@ skipping 179 matching lines @@
     }
   }
 
   return NSRectFromCGRect(rect.ToCGRect());
 }
 
 - (BOOL)shouldResizeContentView {
   return !isEmbeddingFullscreenWidget_ || !blockFullscreenResize_;
 }
 
+- (BOOL)isPopup {
+  return isPopup_;
+}
+
 @end