Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 1790663003: Fix for flash fullscreen animations on OSX (Closed)

Created:
4 years, 9 months ago by spqchan
Modified:
4 years, 9 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix for flash fullscreen animations inside popups on OSX Removed intermediate resizes of the fullscreen widget inside TabContentsContainerView. BUG=566588 Committed: https://crrev.com/ce3c4cbf6353f9953cc71edfc9f5e49ea4ecd248 Cr-Commit-Position: refs/heads/master@{#381053}

Patch Set 1 #

Patch Set 2 : whitespace #

Patch Set 3 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -7 lines) Patch
M chrome/browser/ui/cocoa/browser_window_controller_private.mm View 1 2 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/browser/ui/cocoa/tab_contents/tab_contents_controller.mm View 1 4 chunks +10 lines, -2 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
spqchan
PTAL
4 years, 9 months ago (2016-03-11 23:46:18 UTC) #4
erikchen
lgtm
4 years, 9 months ago (2016-03-12 00:00:00 UTC) #5
spqchan
+avi for OWNERS
4 years, 9 months ago (2016-03-12 00:03:26 UTC) #7
Avi (use Gerrit)
lgtm stampity stamp
4 years, 9 months ago (2016-03-12 22:06:28 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1790663003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1790663003/40001
4 years, 9 months ago (2016-03-14 19:33:06 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 9 months ago (2016-03-14 20:07:31 UTC) #13
commit-bot: I haz the power
4 years, 9 months ago (2016-03-14 20:08:51 UTC) #15
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/ce3c4cbf6353f9953cc71edfc9f5e49ea4ecd248
Cr-Commit-Position: refs/heads/master@{#381053}

Powered by Google App Engine
This is Rietveld 408576698