Touch Action could cause wheel gestures to be filtered.

Touch Action could cause wheel gestures to be filtered.

If the source device is not touchscreen the touch action filter
should not do anything. A certain drop list in
Google maps was failing to scroll via wheel scrolling because it had
installed a touch action none filter.

BUG=607495
Committed: https://crrev.com/3a5f4dbe106611593f05ba7ae163d1660f219f6a
Cr-Commit-Position: refs/heads/master@{#393348}

[dtapuska, 2016-05-12 15:49:26]

Description was changed from

==========
Touch Action could cause wheel gestures to be filtered.

If the source device is not touchscreen the touch action filter
should not do anything.

BUG=607495
==========

to

==========
Touch Action could cause wheel gestures to be filtered.

If the source device is not touchscreen the touch action filter
should not do anything.

BUG=607495
==========

[dtapuska, 2016-05-12 15:49:26]

dtapuska@chromium.org changed reviewers:
+ tdresser@chromium.org

[dtapuska, 2016-05-12 15:49:58]

Description was changed from

==========
Touch Action could cause wheel gestures to be filtered.

If the source device is not touchscreen the touch action filter
should not do anything.

BUG=607495
==========

to

==========
Touch Action could cause wheel gestures to be filtered.

If the source device is not touchscreen the touch action filter
should not do anything. Google maps was failing to
scroll via wheel scrolling because it had
installed a touch action filter.

BUG=607495
==========

[dtapuska, 2016-05-12 15:50:19]

Description was changed from

==========
Touch Action could cause wheel gestures to be filtered.

If the source device is not touchscreen the touch action filter
should not do anything. Google maps was failing to
scroll via wheel scrolling because it had
installed a touch action filter.

BUG=607495
==========

to

==========
Touch Action could cause wheel gestures to be filtered.

If the source device is not touchscreen the touch action filter
should not do anything. A certain drop list in 
Google maps was failing to scroll via wheel scrolling because it had
installed a touch action filter.

BUG=607495
==========

[dtapuska, 2016-05-12 15:50:28]

Description was changed from

==========
Touch Action could cause wheel gestures to be filtered.

If the source device is not touchscreen the touch action filter
should not do anything. A certain drop list in 
Google maps was failing to scroll via wheel scrolling because it had
installed a touch action filter.

BUG=607495
==========

to

==========
Touch Action could cause wheel gestures to be filtered.

If the source device is not touchscreen the touch action filter
should not do anything. A certain drop list in 
Google maps was failing to scroll via wheel scrolling because it had
installed a touch action none filter.

BUG=607495
==========

[dtapuska, 2016-05-12 15:54:29]

dtapuska@chromium.org changed reviewers:
+ sadrul@chromium.org

[dtapuska, 2016-05-12 15:55:31]

Can I please have a quick review on this? I think this needs to be merged into
51.

[tdresser, 2016-05-12 19:19:19]

LGTM

https://codereview.chromium.org/1971273002/diff/1/content/browser/renderer_ho...
File content/browser/renderer_host/input/touch_action_filter_unittest.cc
(right):

https://codereview.chromium.org/1971273002/diff/1/content/browser/renderer_ho...
content/browser/renderer_host/input/touch_action_filter_unittest.cc:119: 2, 3,
blink::WebGestureDeviceTouchpad);
I'd slightly prefer that this be a separate test.

[sadrul, 2016-05-12 19:20:57]

lgtm

[dtapuska, 2016-05-12 20:03:54]

The CQ bit was checked by dtapuska@chromium.org

[dtapuska, 2016-05-12 20:03:55]

The patchset sent to the CQ was uploaded after l-g-t-m from sadrul@chromium.org,
tdresser@chromium.org
Link to the patchset: https://codereview.chromium.org/1971273002/#ps20001
(title: "Make test separate")

[commit-bot: I haz the power, 2016-05-12 20:04:23]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1971273002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1971273002/20001

[commit-bot: I haz the power, 2016-05-12 20:53:58]

Description was changed from

==========
Touch Action could cause wheel gestures to be filtered.

If the source device is not touchscreen the touch action filter
should not do anything. A certain drop list in 
Google maps was failing to scroll via wheel scrolling because it had
installed a touch action none filter.

BUG=607495
==========

to

==========
Touch Action could cause wheel gestures to be filtered.

If the source device is not touchscreen the touch action filter
should not do anything. A certain drop list in 
Google maps was failing to scroll via wheel scrolling because it had
installed a touch action none filter.

BUG=607495
==========

[commit-bot: I haz the power, 2016-05-12 20:53:59]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-05-12 20:54:57]

Description was changed from

==========
Touch Action could cause wheel gestures to be filtered.

If the source device is not touchscreen the touch action filter
should not do anything. A certain drop list in 
Google maps was failing to scroll via wheel scrolling because it had
installed a touch action none filter.

BUG=607495
==========

to

==========
Touch Action could cause wheel gestures to be filtered.

If the source device is not touchscreen the touch action filter
should not do anything. A certain drop list in
Google maps was failing to scroll via wheel scrolling because it had
installed a touch action none filter.

BUG=607495

Committed: https://crrev.com/3a5f4dbe106611593f05ba7ae163d1660f219f6a
Cr-Commit-Position: refs/heads/master@{#393348}
==========

[commit-bot: I haz the power, 2016-05-12 20:54:58]

Patchset 2 (id:??) landed as
https://crrev.com/3a5f4dbe106611593f05ba7ae163d1660f219f6a
Cr-Commit-Position: refs/heads/master@{#393348}