content/browser/renderer_host/input/render_widget_host_latency_tracker_unittest.cc - Issue 1971273002: Touch Action could cause wheel gestures to be filtered.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/input/render_widget_host_latency_tracker_unittest.cc

Issue 1971273002: Touch Action could cause wheel gestures to be filtered. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Make test separate Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/renderer_host/input/input_router_impl_unittest.cc ('k') | content/browser/renderer_host/input/touch_action_filter.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/input/render_widget_host_latency_tracker_unittest.cc

diff --git a/content/browser/renderer_host/input/render_widget_host_latency_tracker_unittest.cc b/content/browser/renderer_host/input/render_widget_host_latency_tracker_unittest.cc

index 769650d349360d04443e039cbd24b7752a7813be..9b757dc88589a821790c4b755673fd3702700f97 100644

--- a/content/browser/renderer_host/input/render_widget_host_latency_tracker_unittest.cc

+++ b/content/browser/renderer_host/input/render_widget_host_latency_tracker_unittest.cc

@@ -170,7 +170,8 @@ TEST_F(RenderWidgetHostLatencyTrackerTest, TestHistograms) {

TEST_F(RenderWidgetHostLatencyTrackerTest,

LatencyTerminatedOnAckIfRenderingNotScheduled) {

{

- auto scroll = SyntheticWebGestureEventBuilder::BuildScrollBegin(5.f, -5.f);

+ auto scroll = SyntheticWebGestureEventBuilder::BuildScrollBegin(

+ 5.f, -5.f, blink::WebGestureDeviceTouchscreen);

ui::LatencyInfo scroll_latency;

AddFakeComponents(*tracker(), &scroll_latency);

// Don't include the rendering schedule component, since we're testing the

@@ -313,7 +314,8 @@ TEST_F(RenderWidgetHostLatencyTrackerTest, InputCoordinatesPopulated) {

}

TEST_F(RenderWidgetHostLatencyTrackerTest, ScrollLatency) {

- auto scroll_begin = SyntheticWebGestureEventBuilder::BuildScrollBegin(5, -5);

+ auto scroll_begin = SyntheticWebGestureEventBuilder::BuildScrollBegin(

+ 5, -5, blink::WebGestureDeviceTouchscreen);

ui::LatencyInfo scroll_latency;

scroll_latency.AddLatencyNumber(ui::INPUT_EVENT_LATENCY_ORIGINAL_COMPONENT, 0,

0);