content/browser/web_contents/web_contents_view_aura_browsertest.cc - Issue 1971273002: Touch Action could cause wheel gestures to be filtered.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/web_contents/web_contents_view_aura_browsertest.cc

Issue 1971273002: Touch Action could cause wheel gestures to be filtered. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Make test separate Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/renderer_host/input/touch_action_filter_unittest.cc ('k') | content/common/input/synthetic_web_input_event_builders.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/web_contents/web_contents_view_aura_browsertest.cc

diff --git a/content/browser/web_contents/web_contents_view_aura_browsertest.cc b/content/browser/web_contents/web_contents_view_aura_browsertest.cc

index 0c0a360e8e749b78465354bba7cf46651970b2e2..a06161ba28449e11acec42abe9d43cbc70545979 100644

--- a/content/browser/web_contents/web_contents_view_aura_browsertest.cc

+++ b/content/browser/web_contents/web_contents_view_aura_browsertest.cc

@@ -958,7 +958,8 @@ IN_PROC_BROWSER_TEST_F(WebContentsViewAuraTest,

ASSERT_EQ(INPUT_EVENT_ACK_STATE_NOT_CONSUMED, filter()->last_ack_state());

blink::WebGestureEvent scroll_begin =

- SyntheticWebGestureEventBuilder::BuildScrollBegin(1, 1);

+ SyntheticWebGestureEventBuilder::BuildScrollBegin(

+ 1, 1, blink::WebGestureDeviceTouchscreen);

GetRenderWidgetHost()->ForwardGestureEventWithLatencyInfo(

scroll_begin, ui::LatencyInfo());

// Scroll begin ignores ack disposition, so don't wait for the ack.