Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(239)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1971193002: Patches to support Dart VM patch files in dart2js. (Closed)

Created:
4 years, 7 months ago by ahe
Modified:
3 years, 11 months ago
Reviewers:
Johnni Winther, kasperl
CC:
rasta-dart+reviews_googlegroups.com
Base URL:
sso://user/ahe/dart-sdk@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patches to support Dart VM patch files in dart2js.

Patch Set 1 #

Patch Set 2 : Changes for CL 1976603002 #

Patch Set 3 : Undo warning nerfing and tweak VM patch files. #

Patch Set 4 : More patch file tweaks and fix currentElement bugs in dartjs. #

Patch Set 5 : White space changes. #

Patch Set 6 : Custom MirrorsUsed analyzer and warnings. #

Patch Set 7 : #

Patch Set 8 : #

Patch Set 9 : #

Patch Set 10 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+388 lines, -161 lines) Patch
M codereview.settings View 7 1 chunk +7 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/common/tasks.dart View 1 2 3 7 1 chunk +16 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/compiler.dart View 1 2 3 4 5 6 7 8 6 chunks +23 lines, -7 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/backend.dart View 7 1 chunk +1 line, -3 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/patch_resolver.dart View 2 2 chunks +3 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/library_loader.dart View 1 2 3 4 5 6 7 8 7 chunks +24 lines, -11 lines 0 comments Download
M pkg/compiler/lib/src/parser/element_listener.dart View 1 2 3 4 5 6 1 chunk +10 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/parser/listener.dart View 1 2 3 4 5 6 2 chunks +16 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/parser/parser.dart View 1 2 3 4 5 6 7 5 chunks +38 lines, -8 lines 0 comments Download
M pkg/compiler/lib/src/patch_parser.dart View 1 2 3 4 5 6 chunks +60 lines, -5 lines 0 comments Download
M pkg/compiler/lib/src/resolution/class_hierarchy.dart View 1 2 3 4 5 6 7 6 chunks +18 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/resolution/constructors.dart View 1 2 3 4 5 6 1 chunk +4 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/resolution/members.dart View 1 2 3 4 5 6 7 8 1 chunk +2 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/resolution/resolution.dart View 1 2 3 4 5 6 7 2 chunks +4 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/resolution/send_resolver.dart View 1 2 3 4 5 6 2 chunks +10 lines, -6 lines 0 comments Download
M pkg/compiler/lib/src/resolution/type_resolver.dart View 1 2 3 4 5 6 7 8 9 1 chunk +2 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/scanner/scanner_task.dart View 1 2 3 4 1 chunk +11 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/tokens/keyword.dart View 1 chunk +5 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/tree/nodes.dart View 1 2 3 4 5 6 1 chunk +5 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/typechecker.dart View 7 1 chunk +5 lines, -0 lines 0 comments Download
M runtime/bin/socket_patch.dart View 1 2 3 4 5 6 5 chunks +5 lines, -6 lines 0 comments Download
M runtime/lib/convert_patch.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M runtime/lib/core_patch.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M runtime/lib/double_patch.dart View 1 chunk +5 lines, -5 lines 0 comments Download
M runtime/lib/errors_patch.dart View 1 2 3 2 chunks +6 lines, -5 lines 0 comments Download
M runtime/lib/expando_patch.dart View 1 2 1 chunk +1 line, -1 line 0 comments Download
M runtime/lib/immutable_map.dart View 1 2 5 chunks +6 lines, -6 lines 0 comments Download
M runtime/lib/integers_patch.dart View 1 chunk +1 line, -1 line 0 comments Download
M runtime/lib/internal_patch.dart View 1 chunk +0 lines, -30 lines 0 comments Download
M runtime/lib/isolate_patch.dart View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M runtime/lib/math_patch.dart View 1 2 1 chunk +9 lines, -9 lines 0 comments Download
M runtime/lib/string_patch.dart View 1 chunk +0 lines, -6 lines 0 comments Download
M runtime/lib/symbol_patch.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/core/bool.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M sdk/lib/core/errors.dart View 1 2 3 4 3 chunks +17 lines, -11 lines 0 comments Download
M sdk/lib/core/expando.dart View 1 2 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/core/null.dart View 1 chunk +4 lines, -4 lines 0 comments Download
M sdk/lib/core/object.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/developer/extension.dart View 1 2 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/developer/profiler.dart View 1 2 3 chunks +3 lines, -5 lines 0 comments Download
M sdk/lib/internal/internal.dart View 1 2 1 chunk +48 lines, -0 lines 0 comments Download
M sdk/lib/internal/symbol.dart View 2 chunks +3 lines, -1 line 0 comments Download
M sdk/lib/io/file_system_entity.dart View 1 2 1 chunk +1 line, -0 lines 0 comments Download

Dependent Patchsets:

Issue 2108673002 Patch 1

Messages

Total messages: 3 (2 generated)
ahe
4 years, 7 months ago (2016-05-12 13:37:50 UTC) #2 
RFC: I'm not planning on submitting this in its current state.

These are the changes I've made so far to dart2js and Dart VM patch files.

Powered by Google App Engine
This is Rietveld 408576698